Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GCSHelper to upload test result #2078

Merged

Conversation

numerology
Copy link

@numerology numerology commented Sep 10, 2019

Switch to an implemented helper function without re-inventing the wheels.


This change is Reviewable

@numerology numerology changed the title [WIP] Use GCSHelper to upload test result Use GCSHelper to upload test result Sep 10, 2019
…se-gcs-client-to-upload-test-result

# Conflicts:
#	test/sample-test/sample_test_launcher.py
@numerology
Copy link
Author

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 10, 2019

/lgtm

@numerology
Copy link
Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a4fa1ed into kubeflow:master Sep 10, 2019
@numerology numerology deleted the use-gcs-client-to-upload-test-result branch September 10, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants