Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema validation for sample test config yaml #2000

Merged
merged 3 commits into from
Aug 30, 2019

Conversation

numerology
Copy link

@numerology numerology commented Aug 30, 2019

Sample test config yaml specs should follow the validation provided in schema.config.yaml
If the validation fails, a ValueError will be raised by yamale.

Part of #1750


This change is Reviewable

@gaoning777
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology numerology merged commit 5ac9b04 into kubeflow:master Aug 30, 2019
@numerology numerology deleted the config-yaml-schema-validate branch August 30, 2019 18:34
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* multi-model serving with servingruntime

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* remove model uri env variable in kserve mlserver servingruntime

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* added mlserver defaults in mutator

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants