Use GCP external Stackdriver links #1552
Conversation
|
Hello! Thank you for this PR! Looks good to me, but you'll need to update the snapshot tests before this can be submitted. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
derekhh
force-pushed
the
derekhh_use-external-stackdriver-link
branch
from
4afb20e
to
511d988
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
/test kubeflow-pipeline-sample-test |
|
/test kubeflow-pipeline-sample-test |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @rileyjbauer :) |
|
Thank you @derekhh ! |
Background
#1310 added links to show Stackdriver logs. However, the links seem to be some Google-internal links.
Changes
In this PR, I updated the links to using
console.cloud.google.com.Test Plan
Verified manually that by changing the prefix from
pantheon.corp.google.comtoconsole.cloud.google.comand keep the rest of the URL the same, we can correctly fetch the logs from Stackdriver k8s logs.I was not able to fetch the logs from Legacy Stackdriver logging though but I don't think that's an issue of this PR.
This change is