Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Added kfp.run_pipeline_func_on_cluster function (alias) #1521

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jun 18, 2019

This commit adds alias to the kfp.Client.create_run_from_pipeline_func method as the root kfp.run_pipeline_func_on_cluster function.
In future more runners can be added (local, etc).

Currently the running the pipeline operation is performed using the API server client concept. I want to add a way to run a pipeline without thinking of server API clients. This way all runners can be grouped in the same place. Also, this way, the compilation options do not creep into the kfp.Client class.


This change is Reviewable

This commit adds alias to the kfp.Client.create_run_from_pipeline_func method as the root kfp.run_pipeline_func_on_cluster function.
In future more runners can be added (local, etc).
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 14, 2019

@gaoning777 Can you please take a look?

from . import Client


def run_pipeline_func_on_cluster(pipeline_func: Callable, arguments: Mapping[str, str], run_name : str = None, experiment_name : str = None, kfp_client : Client = None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace after variable names. Otherwise lgtm.

@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 30, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 30, 2019

/retest

2 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 30, 2019

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 3, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit ecd93a5 into kubeflow:master Sep 3, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Update s3 docs

* Update output

* Update s3 region annotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants