Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Use different volume names for different secrets #1379

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented May 23, 2019

Fixes #1376


This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 24, 2019

/test kubeflow-pipeline-e2e-test

3 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 24, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 24, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 24, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 30, 2019

/cc @IronPan @gaoning777 @hongye-sun

@IronPan
Copy link
Member

IronPan commented Jun 5, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 6, 2019

/test kubeflow-pipeline-e2e-test

2 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 6, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 6, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 90214f5 into kubeflow:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using admin-gcp-sa and user-gcp-sa for different ContainerOp in same pipeline doesn't work
5 participants