Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the basic samples README #129

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Conversation

sarahmaddox
Copy link
Contributor

@sarahmaddox sarahmaddox commented Nov 7, 2018

Fixed a link. Clarified YAML vs TAR format for workflow specification. Made other textual improvements.


This change is Reviewable

Fixed a link. Clarified YAML vs TAR format for workflow specification. Made other textual improvements.
samples/basic/README.md Outdated Show resolved Hide resolved
@qimingj
Copy link
Contributor

qimingj commented Nov 7, 2018

/lgtm

@qimingj
Copy link
Contributor

qimingj commented Nov 7, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8da65c5 into master Nov 7, 2018
@IronPan IronPan deleted the sarahmaddox-basic-README branch June 4, 2019 07:31
HumairAK added a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
fix(backend): add PR name substitution for scheduled runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants