-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve doc for gcp components. #1049
Changes from 8 commits
39c731d
cc49118
c381508
c550bc6
b65d3b1
748089a
f69faba
7c576c4
0f27300
e0b5e68
ab18ba2
ed5e342
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,8 @@ | |
|
||
name: Bigquery - Query | ||
description: | | ||
Submit a query to Bigquery service and write outputs to a GCS blob. | ||
A Kubeflow Pipeline component to submit a query to Google Cloud Bigquery | ||
service and dump outputs to a Google Cloud Storage blob. | ||
inputs: | ||
- name: query | ||
description: 'The query used by Bigquery service to fetch the results.' | ||
|
@@ -33,20 +34,23 @@ inputs: | |
default: '' | ||
type: String | ||
- name: output_gcs_path | ||
description: 'The GCS blob path to dump the query results to.' | ||
description: 'The path to the Cloud Storage bucket to store the query output.' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be honest, the word "bucket" is confusing here. You've probably meant "The path of GCS directory" or "The path of GCS file". There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a suggested change from tech writer. I'd like to follow their suggestion to make it consistent with other AIHub docs. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK. |
||
default: '' | ||
type: GCSPath | ||
- name: dataset_location | ||
description: 'The location to create the dataset. Defaults to `US`.' | ||
default: 'US' | ||
type: String | ||
- name: job_config | ||
description: 'The full config spec for the query job.' | ||
description: >- | ||
The full config spec for the query job.See | ||
[QueryJobConfig](https://googleapis.github.io/google-cloud-python/latest/bigquery/generated/google.cloud.bigquery.job.QueryJobConfig.html#google.cloud.bigquery.job.QueryJobConfig) | ||
for details. | ||
default: '' | ||
type: Dict | ||
outputs: | ||
- name: output_gcs_path | ||
description: 'The GCS blob path to dump the query results to.' | ||
description: 'The path to the Cloud Storage bucket containing the query output in CSV format.' | ||
type: GCSPath | ||
implementation: | ||
container: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is %%capture command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used to hide the outputs from the cell. It's usually not quite useful to show pip install logs here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we still need errors to be output.
https://ipython.readthedocs.io/en/stable/interactive/magics.html#cellmagic-capture shows a way to not capture stderr.
however, when I tried it in my notebook with !pip install, it does not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW,
pip
has the--quiet
option.