remove jupyter hub link from UI #1046
Conversation
|
/hold |
|
fix #1029 |
| @@ -195,6 +195,7 @@ export default class SideNav extends React.Component<SideNavProps, SideNavState> | |||
|
|
|||
| this.state = { | |||
| collapsed, | |||
| // Set jupyterHubAvailable to false so UI don't show Jupyter Hub link | |||
There was a problem hiding this comment.
Why not just remove the references entirely?
There was a problem hiding this comment.
I believe we are going to hyperlink the new Jupyter UI in future
There was a problem hiding this comment.
we are not entirely sure what the plan is. it can still be an entrypoint for new ui, or jaas on gcp. it's safer to keep it but just my opinion.
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Set jupyterHubAvailable flag to always false so we don't show the link.
/assign @rileyjbauer
This change is