Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving and retrieving logs from persistent volume #940

Closed
animeshsingh opened this issue Mar 8, 2019 · 1 comment
Closed

Moving and retrieving logs from persistent volume #940

animeshsingh opened this issue Mar 8, 2019 · 1 comment

Comments

@animeshsingh
Copy link
Contributor

We are running into issues where pipeline logs are getting wiped out from IKS based on rotation policy .Currently, the latest Argo executor could save logs to S3 persistent volume when the archiving flag is enabled.

However, Kubeflow Pipeline frontend is getting the logs using K8S API.
https://github.com/kubeflow/pipelines/blob/master/frontend/server/k8s-helper.ts#L120-L129

Therefore, we need to modify the above function to something similar to what Argo did to their frontend, so our logs could be persistent.

https://github.com/argoproj/argo-ui/pull/15/files#diff-84cac750d2884ddb71e3f362ae241797R131
https://github.com/argoproj/argo-ui/blob/master/src/api/app.ts#L134-L160

@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

Added your suggestion to #844

Resolving in favor of #844

@vicaire vicaire closed this as completed Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants