Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAP host shouldn't be restricted to a cloud endpoint url #2244

Closed
andrewsmartin opened this issue Sep 26, 2019 · 5 comments · Fixed by #3003
Closed

IAP host shouldn't be restricted to a cloud endpoint url #2244

andrewsmartin opened this issue Sep 26, 2019 · 5 comments · Fixed by #3003

Comments

@andrewsmartin
Copy link
Contributor

In 8d5ec83#diff-1f65a44a2187458da0f00e0ebbe730e5R142-R145, the logic for self._is_iap_host uses a regex to ensure that the host name is of the form https://<deployment>.endpoints.<project>.cloud.goog/pipeline. This breaks for us, because we use a different hostname, and thus when trying to connect via IAP an auth token is not generated.

We are able to workaround this by overriding the client and def _is_iap_host(self, host, client_id), but just wanted to raise this issue here.

@jlewi
Copy link
Contributor

jlewi commented Sep 26, 2019

/cc @IronPan @jessiezcc

@chensun
Copy link
Member

chensun commented Feb 5, 2020

/cc @chensun

@james-jwu james-jwu assigned rmgogogo and unassigned james-jwu Feb 5, 2020
@james-jwu
Copy link
Contributor

Assigning to Renmin for triage

@chensun
Copy link
Member

chensun commented Feb 6, 2020

/assign @chensun

@chensun
Copy link
Member

chensun commented Feb 6, 2020

/unassign @rmgogogo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants