-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test for the component build(use multiple output sample) #2109
Comments
This sample as well: https://github.com/kubeflow/pipelines/tree/master/samples/core/component_build |
multiple_output sample is not tested, yet |
Is the func_to_container_op conversion necessary for the tests? |
It's not necessary. I was just going with what you put in the description of this issue: "We can convert it to use the new func_to_containerop and add the test to the e2e.". |
SGTM. Let's add the test first then. |
@gaoning777 Should we close this issue since both samples are now covered by sample tests? |
This issue is to track adding a sample test for the component build(func_to_containerop).
Currently we have a sample https://github.com/kubeflow/pipelines/tree/master/samples/core/multiple_outputs, which uses the build_python_component function. We can convert it to use the new func_to_containerop and add the test to the e2e.
The text was updated successfully, but these errors were encountered: