Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all container APIs through container op #204

Closed
IronPan opened this issue Nov 11, 2018 · 7 comments
Closed

Support all container APIs through container op #204

IronPan opened this issue Nov 11, 2018 · 7 comments
Assignees
@hongye-sun
Labels
area/sdk/dsl/compiler area/sdk/dsl priority/p0

Comments

@IronPan
Copy link
Member

IronPan commented Nov 11, 2018

It looks like currently we only expose a subset of the container API through container op.
https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/dsl/_container_op.py#L30

Does it make sense to expose all container APIs? Or is it already supported?
For example, I have a shared container with multiple source code directories available. I wish to be able to customize the workingdir for my container.
@IronPan IronPan mentioned this issue Nov 11, 2018
Merged
@IronPan
Copy link
Member Author

IronPan commented Nov 12, 2018

Another use case would be setting environment variable.

@IronPan
Copy link
Member Author

IronPan commented Nov 15, 2018

Another use case would be attaching volumes with secret for accessing GCP, S3 etc.

@vicaire vicaire assigned hongye-sun and unassigned Ark-kun and qimingj Mar 26, 2019
@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

@hongye-sun, I am guessing that this will be resolved as part of this PR: #879. Could you please confirm?

@hongye-sun
Copy link
Contributor

Yes.

@vicaire
Copy link
Contributor

vicaire commented Mar 27, 2019

Thanks!

@vicaire
Copy link
Contributor

vicaire commented Mar 27, 2019

Pending #879.

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 25, 2019

Done.

@Ark-kun Ark-kun closed this as completed Apr 25, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@jc2729 @k8s-ci-robot
Add pb2internal unit tests for TF2OpenAPI (kubeflow#204)
0d840b9 
* Add tests for pb2internal

* Select exactly one user-requested SigDef to transform

* Keep internal model as holding []s of MetaGraphs and SigDefs to
support extending this transformation for multiple graphs or SigDefs

* Save single structs instead of lists of 1 elem

* Represent full SavedModel

* Identify MetaGraphs and SigDefs

* Re-organize helper method

* Rearrange methods

* Fix formatting
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@Tomcli @animeshsingh
Enable artifacts as default (kubeflow#204)
fcd4308 
* enable artifacts as default

* Apply suggestions from code review

Co-authored-by: Animesh Singh <singhan@us.ibm.com>

* Update sdk/FEATURES.md

Co-authored-by: Animesh Singh <singhan@us.ibm.com>

* address comments

* Apply suggestions from code review

Co-authored-by: Animesh Singh <singhan@us.ibm.com>

Co-authored-by: Animesh Singh <singhan@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hongye-sun hongye-sun

Labels
area/sdk/dsl/compiler area/sdk/dsl priority/p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Ark-kun @IronPan @qimingj @vicaire @hongye-sun