Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Parametrize launcher image in KFPV2 #10229

Closed
rimolive opened this issue Nov 10, 2023 · 6 comments · Fixed by #10269
Closed

[feature] Parametrize launcher image in KFPV2 #10229

rimolive opened this issue Nov 10, 2023 · 6 comments · Fixed by #10269

Comments

@rimolive
Copy link
Member

Feature Area

/area backend

What feature would you like to see?

Launcher image could be parametrized in a way that users can make use of the following tasks:

  • Work on a custom launcher image for additional checks before running a pipeline step
  • Run Kubeflow Pipelines in a disconnected environment

What is the use case or pain point?

Launcher image is hard-coded, and this is bad practice IMHO. We should be able to let users parameterize any image used by KFP, and launcher image is that example.

Is there a workaround currently?

There is no possible workarounds


Love this idea? Give it a 👍.

@nirajkl
Copy link

nirajkl commented Nov 14, 2023

Hi @rimolive ,

please suggest on timelines when the changes will be implemented.

thanks.

@and-1
Copy link

and-1 commented Nov 14, 2023

It would be great If you parametrize driver image also

@rimolive
Copy link
Member Author

rimolive commented Dec 4, 2023

@nirajkl @and-1 Please check latest status. We have an ongoing PR to introduce launcher and driver image parametrization.

@chensun
Copy link
Member

chensun commented Dec 8, 2023

This was implemented and released in KFP 2.0.5

@thesuperzapper
Copy link
Member

I want to highlight that V2_LAUNCHER_IMAGE will NOT affect V2_COMPATIBLE mode runs.

These runs will still use the _DEFAULT_LAUNCHER_IMAGE which was hard-coded in the version of the kfp SDK you are using which is usually gcr.io/ml-pipeline/kfp-launcher:1.8.7:

@rimolive
Copy link
Member Author

v2-compatible mode is no longer supported, and the ideal path is upgrade kfp to the latest release. We're currently in 2.1.0 but we're planning to release 2.2.0 for Kubeflow 1.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants