Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Improve Logging in the KFP components #10105

Closed
DharmitD opened this issue Oct 16, 2023 · 3 comments · Fixed by #10288
Closed

[feature] Improve Logging in the KFP components #10105

DharmitD opened this issue Oct 16, 2023 · 3 comments · Fixed by #10288

Comments

@DharmitD
Copy link
Contributor

Feature Area

/area backend

What feature would you like to see?

We need to enable logging for KFP components (APIServer, Persistence Agent, Scheduled Workflow) through manifest parameters and inject through environment variables in all pods to enable debugging.
This would involve updating the main.go for each of these components, in order to have a log-level parameter that could either be set to info, error, debug, etc levels, and also updating respective components' dockerfiles.

What is the use case or pain point?

Is there a workaround currently?


Love this idea? Give it a 👍.

@chensun
Copy link
Member

chensun commented Oct 19, 2023

logging for KFP components (APIServer, Persistence Agent, Scheduled Workflow)

The cluster admin would have access to such logging, I don't think KFP users needs to debug through such information.

@rimolive
Copy link
Member

rimolive commented Oct 26, 2023

logging for KFP components (APIServer, Persistence Agent, Scheduled Workflow)

The cluster admin would have access to such logging, I don't think KFP users needs to debug through such information.

I think this issue needs clarification. The idea is to give users a way to easily specify the logging level for KFP components if needed. Instructions on how to do that are in the code, so either clarify in the KFP documentation how to set the logging level or add an env var in each KFP component Deployment to do that. If we can do both, the better.

I got a scenario where API Server was failling on DB connection (I knew it was because I had all the console message sequence in my head), but I saw no more than 2 lines in console. No errors returned. And I realized that default logging level is warning.

@DharmitD
Copy link
Contributor Author

@chensun following up on this thread, any thoughts / suggestions based on @rimolive 's explanation above?

Could we move this task to "ready" from "needs more info"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants