Skip to content

Commit

Permalink
fix(sdk): use a meaningful link text in ipython (#4570)
Browse files Browse the repository at this point in the history
  • Loading branch information
porridge authored Oct 7, 2020
1 parent fece3b1 commit a840ce7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions sdk/python/kfp/_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ def create_experiment(self, name, description=None, namespace=None):
if self._is_ipython():
import IPython
html = \
('Experiment link <a href="%s/#/experiments/details/%s" target="_blank" >here</a>'
('<a href="%s/#/experiments/details/%s" target="_blank" >Experiment details</a>.'
% (self._get_url_prefix(), experiment.id))
IPython.display.display(IPython.display.HTML(html))
return experiment
Expand Down Expand Up @@ -507,7 +507,7 @@ def run_pipeline(self, experiment_id, job_name, pipeline_package_path=None, para

if self._is_ipython():
import IPython
html = ('Run link <a href="%s/#/runs/details/%s" target="_blank" >here</a>'
html = ('<a href="%s/#/runs/details/%s" target="_blank" >Run details</a>.'
% (self._get_url_prefix(), response.run.id))
IPython.display.display(IPython.display.HTML(html))
return response.run
Expand Down Expand Up @@ -840,7 +840,7 @@ def upload_pipeline(
response = self._upload_api.upload_pipeline(pipeline_package_path, name=pipeline_name, description=description)
if self._is_ipython():
import IPython
html = 'Pipeline link <a href=%s/#/pipelines/details/%s>here</a>' % (self._get_url_prefix(), response.id)
html = '<a href=%s/#/pipelines/details/%s>Pipeline details</a>.' % (self._get_url_prefix(), response.id)
IPython.display.display(IPython.display.HTML(html))
return response

Expand Down Expand Up @@ -878,7 +878,7 @@ def upload_pipeline_version(

if self._is_ipython():
import IPython
html = 'Pipeline link <a href=%s/#/pipelines/details/%s>here</a>' % (self._get_url_prefix(), response.id)
html = '<a href=%s/#/pipelines/details/%s>Pipeline details</a>.' % (self._get_url_prefix(), response.id)
IPython.display.display(IPython.display.HTML(html))
return response

Expand Down

0 comments on commit a840ce7

Please sign in to comment.