From 16493abb3df2e165b0301140b8f0fc59a701d271 Mon Sep 17 00:00:00 2001 From: Alexey Volkov Date: Mon, 10 Feb 2020 14:29:51 -0800 Subject: [PATCH] Renamed the test case --- sdk/python/tests/compiler/compiler_tests.py | 4 ++-- ..._clashes.py => parallelfor_item_argument_resolving.py} | 4 ++-- ...shes.yaml => parallelfor_item_argument_resolving.yaml} | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) rename sdk/python/tests/compiler/testdata/{parallelfor_name_clashes.py => parallelfor_item_argument_resolving.py} (94%) rename sdk/python/tests/compiler/testdata/{parallelfor_name_clashes.yaml => parallelfor_item_argument_resolving.yaml} (99%) diff --git a/sdk/python/tests/compiler/compiler_tests.py b/sdk/python/tests/compiler/compiler_tests.py index 81549370a64..5f12f4c18de 100644 --- a/sdk/python/tests/compiler/compiler_tests.py +++ b/sdk/python/tests/compiler/compiler_tests.py @@ -783,8 +783,8 @@ def test_withparam_output_dict(self): def test_withparam_lightweight_out(self): self._test_py_compile_yaml('loop_over_lightweight_output') - def test_parallelfor_name_clashes(self): - self._test_py_compile_yaml('parallelfor_name_clashes') + def test_parallelfor_item_argument_resolving(self): + self._test_py_compile_yaml('parallelfor_item_argument_resolving') def test_py_input_artifact_raw_value(self): """Test pipeline input_artifact_raw_value.""" diff --git a/sdk/python/tests/compiler/testdata/parallelfor_name_clashes.py b/sdk/python/tests/compiler/testdata/parallelfor_item_argument_resolving.py similarity index 94% rename from sdk/python/tests/compiler/testdata/parallelfor_name_clashes.py rename to sdk/python/tests/compiler/testdata/parallelfor_item_argument_resolving.py index ebcc2ee01e4..ebcb8c28024 100644 --- a/sdk/python/tests/compiler/testdata/parallelfor_name_clashes.py +++ b/sdk/python/tests/compiler/testdata/parallelfor_item_argument_resolving.py @@ -57,7 +57,7 @@ def consume(param1): @kfp.dsl.pipeline() -def parallelfor_name_clashes_pipeline(): +def parallelfor_item_argument_resolving(): produce_str_task = produce_str() produce_list_of_strings_task = produce_list_of_strings() produce_list_of_ints_task = produce_list_of_ints() @@ -80,5 +80,5 @@ def parallelfor_name_clashes_pipeline(): if __name__ == '__main__': import kfp.compiler as compiler - compiler.Compiler().compile(parallelfor_name_clashes_pipeline, __file__ + '.yaml') + compiler.Compiler().compile(parallelfor_item_argument_resolving, __file__ + '.yaml') diff --git a/sdk/python/tests/compiler/testdata/parallelfor_name_clashes.yaml b/sdk/python/tests/compiler/testdata/parallelfor_item_argument_resolving.yaml similarity index 99% rename from sdk/python/tests/compiler/testdata/parallelfor_name_clashes.yaml rename to sdk/python/tests/compiler/testdata/parallelfor_item_argument_resolving.yaml index 4545925f8de..8c9ef5ad996 100644 --- a/sdk/python/tests/compiler/testdata/parallelfor_name_clashes.yaml +++ b/sdk/python/tests/compiler/testdata/parallelfor_item_argument_resolving.yaml @@ -2,12 +2,12 @@ apiVersion: argoproj.io/v1alpha1 kind: Workflow metadata: annotations: - pipelines.kubeflow.org/pipeline_spec: "{\"name\": \"Parallelfor name clashes pipeline\"}" - generateName: parallelfor-name-clashes-pipeline- + pipelines.kubeflow.org/pipeline_spec: "{\"name\": \"Parallelfor item argument resolving pipeline\"}" + generateName: parallelfor-item-argument-resolving- spec: arguments: parameters: [] - entrypoint: parallelfor-name-clashes-pipeline + entrypoint: parallelfor-item-argument-resolving serviceAccountName: pipeline-runner templates: - @@ -474,7 +474,7 @@ spec: - name: produce-str template: produce-str - name: parallelfor-name-clashes-pipeline + name: parallelfor-item-argument-resolving - container: args: