Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto terminate Log Watcher once disconnected from KubeArmor #73

Open
daemon1024 opened this issue May 20, 2022 · 3 comments
Open

Auto terminate Log Watcher once disconnected from KubeArmor #73

daemon1024 opened this issue May 20, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@daemon1024
Copy link
Member

We currently don't terminate our log watchers once we get an EOF from KubeArmor, We need to manually send a SIGKILL or any other relevant signal to stop the process. We should auto exit the watcher and terminate the process once we receive this.

image

Hi, If it is the first time that you contribute to KubeArmor, follow these steps:
Write a comment in this issue thread to let other possible contributors know that you are working on this bug. For eg : Hey all, I would like to work on this issue., checkout Contributing Guide 🔥✨ and feel free to ask anything related to this issue in this thread or on our slack channel ✌🏽

@daemon1024 daemon1024 added enhancement New feature or request good first issue Good for newcomers labels May 20, 2022
@s1ntaxe770r s1ntaxe770r self-assigned this Jun 2, 2022
@s1ntaxe770r
Copy link

@daemon1024 I'll be taking this one

@pk-218
Copy link

pk-218 commented May 23, 2023

Hi @daemon1024, I am able to reproduce the issue.

Steps I followed -

  1. Installed karmor CLI
  2. Run karmor install to install KubeArmor to local K3s cluster
  3. Run wordpress-mysql microservice example as given in the docs.
  4. Run kubectl -n wordpress-mysql exec -it wordpress-c4bf5b44b-lvkbl -- bash -c apt to trigger the ksp-wordpress-block-process KubeArmorSecurityPolicy
  5. Run karmor uninstall to remove KubeArmor from the cluster and cause an error.
  6. Output on terminal is obtained as -
    Screenshot from 2023-05-23 16-44-26
    But the log client doesn't exit.

Can you assign this issue to me?

@daemon1024
Copy link
Member Author

@pk-218 Thanks for taking it up, I see you already have an understanding of the issue but do lemme know if you need some help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants