Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api::patch should only allow modifications to a subset type #175

Closed
clux opened this issue Mar 8, 2020 · 2 comments
Closed

Api::patch should only allow modifications to a subset type #175

clux opened this issue Mar 8, 2020 · 2 comments
Labels
api Api abstraction related apply patch or server-side apply wontfix This will not be worked on

Comments

@clux
Copy link
Member

clux commented Mar 8, 2020

This can be done using some ideas from #143. However, it is made complicated by the json patch format that sits on top of it.

This is why we should try to do it for Api::apply #174 as a starting point (which is likely what most future controllers will use in the future any because patch can be difficult to use directly).

@clux clux added api Api abstraction related apply patch or server-side apply labels Mar 8, 2020
@clux clux added the wontfix This will not be worked on label Aug 9, 2021
@clux
Copy link
Member Author

clux commented Aug 9, 2021

I think this idea is probably a bit too ambitious, particularly when seeing how brittle the serialization can be when looking back at the recent k8s-openapi option unpacking experiment.

Going to close this issue. I don't think we have a clear way to do this, nor is it necessary to do this. If that changes, we can open a new issue.

@clux clux closed this as completed Aug 9, 2021
@clux
Copy link
Member Author

clux commented Oct 11, 2021

Well, an analogue of this was actually done in client-go now under KEP-2155 :: generated apply configuration types, so it might be worth re-examining if we want to pick up #649. But will wait on discussion therein before re-opening this (particularly with other work on protobuf serialization).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Api abstraction related apply patch or server-side apply wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant