Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum supported rustls version is 0.21.4 not 0.21.0 #1340

Closed
MathiasPius opened this issue Nov 11, 2023 · 0 comments · Fixed by #1341
Closed

Minimum supported rustls version is 0.21.4 not 0.21.0 #1340

MathiasPius opened this issue Nov 11, 2023 · 0 comments · Fixed by #1341
Labels
bug Something isn't working

Comments

@MathiasPius
Copy link
Contributor

Current and expected behavior

Building kube-client using the minimal crate versions as specified in Cargo.toml fails.

Reproduction, in kube-client 0.87.1 or crate that relies on it:

$ cargo +nightly update -Zminimal-versions
$ cargo build

Results in:

error[E0599]: no method named `with_client_auth_cert` found for struct `ConfigBuilder` in the current scope
  --> /home/mpd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/kube-client-0.87.1/src/client/tls.rs:56:18
   |
55 | /             config_builder
56 | |                 .with_client_auth_cert(chain, pkey)
   | |                 -^^^^^^^^^^^^^^^^^^^^^ help: there is a method with a similar name: `with_no_client_auth`
   | |_________________|
   | 

Method with_client_auth_cert was only renamed from with_single_cert in rustls 0.21.4 meaning versions prior to 0.21.4 are incompatible with kube-client.

Possible solution

Update minimum rustls dependency in kube-client's Cargo.toml to 0.21.4.

Additional context

kube-client calls rustls::client::builder::ConfigBuilder::.with_client_auth_cert which was named with_single_cert prior to rustls version v0.21.4, making kube-client incompatible with rustls versions <v0.21.4.

Environment

Irrelevant

Configuration and features

No response

Affected crates

kube-client

Would you like to work on fixing this bug?

yes

@MathiasPius MathiasPius added the bug Something isn't working label Nov 11, 2023
MathiasPius added a commit to kubi-zone/zonefile that referenced this issue Nov 11, 2023
clux pushed a commit that referenced this issue Nov 11, 2023
Update kube-client's rustls dependency to 0.21.4

kube-client is incompatible with rustls versions prior to 0.21.4 due to the renaming of rustls::client::builder::ConfigBuilder::.with_client_auth_cert

Fixes #1340

Signed-off-by: Mathias Pius <contact@pius.io>
@clux clux mentioned this issue Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant