Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Controller::watches_stream and Controller::for_stream #1180

Closed
2 tasks done
clux opened this issue Apr 3, 2023 · 0 comments · Fixed by #1187
Closed
2 tasks done

Add Controller::watches_stream and Controller::for_stream #1180

clux opened this issue Apr 3, 2023 · 0 comments · Fixed by #1187
Labels
runtime controller runtime related unstable feature that unstable feature gating

Comments

@clux
Copy link
Member

clux commented Apr 3, 2023

Would you like to work on this feature?

Yes

What problem are you trying to solve?

Allow for stream sharing (#1080) of watched and root streams between controllers.
We can follow the approach in #1173 in general, but may have to slightly tweak the new interfaces based on new inputs that are needed.

Describe the solution you'd like

Add

Documentation, Adoption, Migration Strategy

Unstable feature. Can probably even consolidate the stream sharing features since the proposed Controller:: methods + the ones done in #1173 would be basically fully analogous.

Target crate for feature

kube-runtime

Related

The following issues can be closed after this as a result (given predicates exist):

@clux clux added runtime controller runtime related help wanted Not immediately prioritised, please help! unstable feature that unstable feature gating and removed help wanted Not immediately prioritised, please help! labels Apr 3, 2023
@clux clux changed the title Add Controller::watches_stream and Controller::from_stream Add Controller::watches_stream and Controller::for_stream Apr 4, 2023
@clux clux linked a pull request Apr 5, 2023 that will close this issue
@clux clux closed this as completed in #1187 Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime controller runtime related unstable feature that unstable feature gating
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant