Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable doctests in CI #49

Open
shaneutt opened this issue Aug 20, 2024 · 3 comments
Open

Enable doctests in CI #49

shaneutt opened this issue Aug 20, 2024 · 3 comments
Labels
area/maintenance area/tests good first issue Good for newcomers help wanted Extra attention is needed
Milestone
Initial Pre-Release

Comments

@shaneutt
Copy link
Member

Currently we're not running doctests in CI due to a problem with our generated API code from kopium, wherein the docs generated trigger and then fail testing attempts. The purpose of this task is to straighten that out and make sure we have unit and doctests running for PRs.
@shaneutt shaneutt added this to the Initial Pre-Release milestone Aug 20, 2024
@shaneutt shaneutt self-assigned this Aug 20, 2024
@shaneutt shaneutt mentioned this issue Aug 20, 2024
Merged
@shaneutt shaneutt assigned shaneutt and unassigned shaneutt Aug 20, 2024
@shaneutt
Copy link
Member Author

I've created kube-rs/kopium#264 in order to fix this in kopium itself.

@shaneutt shaneutt added the blocked Progress is halted, work is required elsewhere to continue. label Sep 9, 2024
@clux
Copy link
Member

clux commented Sep 12, 2024

Should be possible now in https://github.com/kube-rs/kopium/releases/tag/0.21.1

@shaneutt
Copy link
Member Author

Thanks @clux and @alexsnaps!

@shaneutt shaneutt added help wanted Extra attention is needed and removed blocked Progress is halted, work is required elsewhere to continue. labels Sep 12, 2024
@shaneutt shaneutt removed their assignment Sep 12, 2024
@shaneutt shaneutt added the good first issue Good for newcomers label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/maintenance area/tests good first issue Good for newcomers help wanted Extra attention is needed
Projects
gateway-api-rs
Status: Todo
Milestone
Initial Pre-Release
Development

No branches or pull requests
2 participants
@clux @shaneutt