Fix credentials not set for ResolveChartVersion default HTTP client (helm#4662)

calebdelnay · Matthew Fisher · commit 19467a536a23 · 2018-09-19T11:25:30.000-07:00
Fixes Issue helm#4299 and Issue helm#4445 Signed-off-by: Caleb Delnay <calebdelnay@gmail.com> (cherry picked from commit fbda50a)
diff --git a/pkg/downloader/chart_downloader.go b/pkg/downloader/chart_downloader.go
@@ -170,8 +170,11 @@ func (c *ChartDownloader) ResolveChartVersion(ref, version string) (*url.URL, ge
 				if err != nil {
 					return u, nil, err
 				}
-				getter, err := getterConstructor(ref, "", "", "")
-				return u, getter, err
+				g, err := getterConstructor(ref, "", "", "")
+				if t, ok := g.(*getter.HttpGetter); ok {
+					t.SetCredentials(c.Username, c.Password)
+				}
+				return u, g, err
 			}
 			return u, nil, err
 		}

Original file line number	Diff line number	Diff line change
`@@ -170,8 +170,11 @@ func (c ChartDownloader) ResolveChartVersion(ref, version string) (url.URL, ge`
`170`	`170`	`if err != nil {`
`171`	`171`	`return u, nil, err`
`172`	`172`	`}`
`173`		`- getter, err := getterConstructor(ref, "", "", "")`
`174`		`- return u, getter, err`
	`173`	`+ g, err := getterConstructor(ref, "", "", "")`
	`174`	`+ if t, ok := g.(*getter.HttpGetter); ok {`
	`175`	`+ t.SetCredentials(c.Username, c.Password)`
	`176`	`+ }`
	`177`	`+ return u, g, err`
`175`	`178`	`}`
`176`	`179`	`return u, nil, err`
`177`	`180`	`}`