Added sync start

[RonShvarz]

kube-HPC/hkube#1887

Added sync function to use with existing algorithms

---

This change is 

[golanha]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @RonShvarz)

---

commands/sync/start.js line 16 at r1 (raw file):

    if (res.result.error || res.error) {
        let msg;
        if (res.result.error.code === 400) {

Check for the specific error message to know that the reason for the failure is that the algorithm doesn't exsist, 400 is still general.

Code quote:

res.result.error.code === 400

---

commands/sync/start.js line 61 at r1 (raw file):

            describe: 'base image for the algorithm',
            type: 'string'
        }

why do we need these parameters?

Code quote:

        env: {
            describe: 'algorithm runtime environment',
            type: 'string',
            choices: ['python', 'nodejs']

        },
        entryPoint: {
            describe: 'the main file of the algorithm',
            type: 'string',
            alias: ['e']
        },
        baseImage: {
            describe: 'base image for the algorithm',
            type: 'string'
        }

[RonShvarz]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @golanha)

---

commands/sync/start.js line 16 at r1 (raw file):

Previously, golanha (Golan Hallel) wrote…

Check for the specific error message to know that the reason for the failure is that the algorithm doesn't exsist, 400 is still general.

Api server's update function concats many required base parameters depending on what is missing from the body,

"return {

error: {

name: options.name,

code: 400,

message: `Error updating ${options.name} ${error.message}`

}

};"

If there requierments change in the future, and i check for their existance in a stream-wise operation, it might not be future proof. Your opinion ?

---

commands/sync/start.js line 61 at r1 (raw file):

Previously, golanha (Golan Hallel) wrote…

why do we need these parameters?

Forgot to cleanup after we decided not to invoke watch from the start function. done

[golanha]

Reviewed 1 of 2 files at r1, 1 of 3 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @RonShvarz)

---

commands/sync/start.js line 32 at r4 (raw file):

        algorithmName: {
            demandOption: true,
            describe: 'The name of the algorithm to sync data into',

files

Code quote:

data

---

commands/sync/stop.js line 30 at r4 (raw file):

        algorithmName: {
            demandOption: true,
            describe: 'The name of the algorithm to sync data into',

The name of the algorithm to stop syncing files into.

Code quote:

The name of the algorithm to sync data into

[RonShvarz]

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @golanha)

---

commands/sync/start.js line 32 at r4 (raw file):

Previously, golanha (Golan Hallel) wrote…

files

Done.

---

commands/sync/stop.js line 30 at r4 (raw file):

Previously, golanha (Golan Hallel) wrote…

The name of the algorithm to stop syncing files into.

Done.