KTOR-8810 Make routing call coroutineContext delegate to engine call

Author: bjhham

ktor-server/ktor-server-core/api/ktor-server-core.api

@@ -1785,6 +1785,7 @@ public final class io/ktor/server/routing/RoutingPathSegmentKind : java/lang/Enu
 }
 
 public final class io/ktor/server/routing/RoutingPipelineCall : io/ktor/server/application/PipelineCall, kotlinx/coroutines/CoroutineScope {
+	public fun <init> (Lio/ktor/server/application/PipelineCall;Lio/ktor/server/routing/RoutingNode;Lio/ktor/server/request/ApplicationReceivePipeline;Lio/ktor/server/response/ApplicationSendPipeline;Lio/ktor/http/Parameters;)V
 	public fun <init> (Lio/ktor/server/application/PipelineCall;Lio/ktor/server/routing/RoutingNode;Lkotlin/coroutines/CoroutineContext;Lio/ktor/server/request/ApplicationReceivePipeline;Lio/ktor/server/response/ApplicationSendPipeline;Lio/ktor/http/Parameters;)V
 	public fun getApplication ()Lio/ktor/server/application/Application;
 	public fun getAttributes ()Lio/ktor/util/Attributes;

ktor-server/ktor-server-core/api/ktor-server-core.klib.api

@@ -1106,6 +1106,7 @@ final class io.ktor.server.routing/RoutingPathSegment { // io.ktor.server.routin
 }
 
 final class io.ktor.server.routing/RoutingPipelineCall : io.ktor.server.application/PipelineCall, kotlinx.coroutines/CoroutineScope { // io.ktor.server.routing/RoutingPipelineCall|null[0]
+    constructor <init>(io.ktor.server.application/PipelineCall, io.ktor.server.routing/RoutingNode, io.ktor.server.request/ApplicationReceivePipeline, io.ktor.server.response/ApplicationSendPipeline, io.ktor.http/Parameters) // io.ktor.server.routing/RoutingPipelineCall.<init>|<init>(io.ktor.server.application.PipelineCall;io.ktor.server.routing.RoutingNode;io.ktor.server.request.ApplicationReceivePipeline;io.ktor.server.response.ApplicationSendPipeline;io.ktor.http.Parameters){}[0]
     constructor <init>(io.ktor.server.application/PipelineCall, io.ktor.server.routing/RoutingNode, kotlin.coroutines/CoroutineContext, io.ktor.server.request/ApplicationReceivePipeline, io.ktor.server.response/ApplicationSendPipeline, io.ktor.http/Parameters) // io.ktor.server.routing/RoutingPipelineCall.<init>|<init>(io.ktor.server.application.PipelineCall;io.ktor.server.routing.RoutingNode;kotlin.coroutines.CoroutineContext;io.ktor.server.request.ApplicationReceivePipeline;io.ktor.server.response.ApplicationSendPipeline;io.ktor.http.Parameters){}[0]
 
     final val application // io.ktor.server.routing/RoutingPipelineCall.application|{}application[0]

ktor-server/ktor-server-core/common/src/io/ktor/server/routing/RoutingPipelineCall.kt

@@ -23,14 +23,29 @@ import kotlin.coroutines.*
 public class RoutingPipelineCall(
     public val engineCall: PipelineCall,
     public val route: RoutingNode,
-    override val coroutineContext: CoroutineContext,
     receivePipeline: ApplicationReceivePipeline,
     responsePipeline: ApplicationSendPipeline,
     public val pathParameters: Parameters
 ) : PipelineCall, CoroutineScope {
+    @Deprecated(level = DeprecationLevel.WARNING, message = "CoroutineContext is delegated to engineCall now.")
+    public constructor(
+        engineCall: PipelineCall,
+        route: RoutingNode,
+        coroutineContext: CoroutineContext,
+        receivePipeline: ApplicationReceivePipeline,
+        responsePipeline: ApplicationSendPipeline,
+        pathParameters: Parameters
+    ) : this(
+        engineCall,
+        route,
+        receivePipeline,
+        responsePipeline,
+        pathParameters
+    )
 
     override val application: Application get() = engineCall.application
     override val attributes: Attributes get() = engineCall.attributes
+    override val coroutineContext: CoroutineContext get() = engineCall.coroutineContext
 
     override val request: RoutingPipelineRequest =
         RoutingPipelineRequest(this, receivePipeline, engineCall.request)

ktor-server/ktor-server-core/common/src/io/ktor/server/routing/RoutingRoot.kt

@@ -94,7 +94,6 @@ public class RoutingRoot(
         val routingApplicationCall = RoutingPipelineCall(
             context.call,
             route,
-            context.coroutineContext,
             receivePipeline,
             responsePipeline,
             parameters

ktor-server/ktor-server-netty/jvm/test/io/ktor/tests/server/netty/NettyEngineTest.kt

@@ -18,6 +18,7 @@ import io.ktor.server.testing.suites.*
 import io.ktor.server.websocket.*
 import io.ktor.websocket.*
 import kotlinx.coroutines.flow.*
+import kotlinx.coroutines.test.TestResult
 import kotlin.test.*
 
 class NettyCompressionTest : CompressionTestSuite<NettyApplicationEngine, NettyApplicationEngine.Configuration>(Netty) {

ktor-server/ktor-server-test-suites/common/src/io/ktor/server/testing/suites/HttpServerCommonTestSuite.kt

@@ -500,12 +500,12 @@ abstract class HttpServerCommonTestSuite<TEngine : ApplicationEngine, TConfigura
     }
 
     @Test
-    fun testParentContextPropagates() = runTest {
+    open fun testParentContextPropagates() = runTest {
         createAndStartServer(
             parent = TestData("parent")
         ) {
             get("/") {
-                val testDataFromParent = kotlin.coroutines.coroutineContext[TestData]
+                val testDataFromParent = call.coroutineContext[TestData]
                 assertNotNull(testDataFromParent, "Context should contain test data from parent")
                 call.respond(HttpStatusCode.OK, testDataFromParent.name)
             }