From c4ac2a23c49b14a627037e0dc543617ef7ad545c Mon Sep 17 00:00:00 2001 From: c9s Date: Tue, 21 Jun 2022 15:27:48 +0800 Subject: [PATCH] remove pre-commit from ci --- .github/workflows/go.yml | 15 --------------- CONTRIBUTING.md | 9 +++++++++ 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index a2f88e5002..333e2b285a 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -32,14 +32,6 @@ jobs: restore-keys: | ${{ runner.os }}-go- - - uses: actions/cache@v2 - with: - path: | - ~/.cache/pip - key: ${{ runner.os }}-pip - restore-keys: | - ${{ runner.os }}-pip - - name: Set up MySQL run: | sudo /etc/init.d/mysql start @@ -56,13 +48,6 @@ jobs: with: go-version: 1.18 - - name: Run pre-commit - run: | - pip install pre-commit - pre-commit install-hooks - pre-commit run markdownlint --files=README.md --verbose - pre-commit run detect-secrets --all-files --verbose - - name: Install Migration Tool run: go install github.com/c9s/rockhopper/cmd/rockhopper@v1.2.1 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3dfe10936c..c92962cdcb 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -22,6 +22,15 @@ If you find an issue to work on, you are welcome to open a PR with a fix. ### Making Changes +Install pre-commit to check your changes before you commit: + + pip install pre-commit + pre-commit install + pre-commit run markdownlint --files=README.md --verbose + pre-commit run detect-secrets --all-files --verbose + +See for more details. + For new large features, such as integrating binance futures contracts, please propose a discussion first before you start working on it. For new small features, you could open a pull request directly.