-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Type Safety in Python Client API #42
base: master
Are you sure you want to change the base?
Conversation
awesome :) could you fix the failing unit tests? otherwise looks good! |
thanks @codekansas . I just fixed the failing unit tests and pushed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this looks really good! Just a few nitpicks to satisfy my ocd
@WT-MM Hope this helps :) |
okay, actually after taking another look at this again, can we keep the protobuf return types if they're typed or use dataclasses? Being able to access values as attributes is probably more ergonomic (e.g. getting Otherwise, it's probably ready to merge in - I'll resolve conflicts and merge in afterwards |
@WT-MM you are right. Having access to the values as attributes is better. |
Description
This PR improves the type safety of the Python client API by ensuring consistent TypedDict usage across all service clients. This makes the API more predictable.
Changes
Testing
make format
for code formattingruff
make test
to verify functionalityRelated Issues
Closes #32