Kafka Demo script #126
Open
Kafka Demo script #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saad Khan <saakhan@redhat.com>
chandrams
reviewed
Feb 13, 2025
chandrams
reviewed
Feb 13, 2025
Signed-off-by: Saad Khan <saakhan@redhat.com>
Signed-off-by: Saad Khan <saakhan@redhat.com>
Contributor
|
@khansaad Is the demo working fine now? Can you please paste the output here. |
Signed-off-by: Saad Khan <saakhan@redhat.com>
Contributor
Author
Contributor
Author
|
chandrams
reviewed
Mar 21, 2025
|
|
||
| ## Demo workflow | ||
|
|
||
| - Reserve a namespace in ephemeral cluster |
Contributor
There was a problem hiding this comment.
Update the readme to remove references to ephemeral/bonfire
Signed-off-by: Saad Khan <saakhan@redhat.com>
Contributor
|
@khansaad Demo doesn't run and fails with this error Kruize pod log error |
Signed-off-by: Saad Khan <saakhan@redhat.com>
Signed-off-by: Saad Khan <saakhan@redhat.com>
Contributor
Author
Fixed the issue as part of PR 1555 |
Contributor
kusumachalasani
left a comment
kusumachalasani
left a comment
There was a problem hiding this comment.
As discussed, please move the console output and intermediate messages to the log.
Also, please include the consumer commands user can try to look into the messages at the end of log.
common/common_helper.sh
Outdated
| if [ ${CLUSTER_TYPE} == "kind" ]; then | ||
| sed -i 's/"isKafkaEnabled" : "false"/"isKafkaEnabled" : "true"/' ${KRUIZE_CRC_DEPLOY_MANIFEST_MINIKUBE} | ||
| # Replace the existing KAFKA_BOOTSTRAP_SERVERS value | ||
| sed -i "s|value: \"kruize-kafka-cluster-kafka-bootstrap.kafka.svc.cluster.local:9092\"|value: \"$BOOTSTRAP_SERVER\"|g" ${KRUIZE_CRC_DEPLOY_MANIFEST_MINIKUBE} |
Contributor
There was a problem hiding this comment.
Trying the demo in multiple namespaces doesn't replace the actual bootstrap server
| # Perform action based on selection | ||
| if [ ${start_demo} -eq 1 ]; then | ||
| echo | ||
| echo "Starting the demo using: " |
Contributor
There was a problem hiding this comment.
Please move all these messages to the log
| kafka_elapsed_time=$(time_diff "${kafka_start_time}" "${kafka_end_time}") | ||
| fi | ||
| elapsed_time=$(time_diff "${start_time}" "${end_time}") | ||
| echo "🕒 Success! Kafka Server setup took ${kafka_elapsed_time} seconds" |
Contributor
There was a problem hiding this comment.
Throws an error when kafka setup is skipped.
| } | ||
|
|
||
| function consume_messages() { | ||
| echo -n "🔄 Consuming recommendations from the recommendations-topic..." |
Contributor
There was a problem hiding this comment.
Can you please include some dots to let user know that kafka is consuming messages and is in progress.
…ver and other cosmetic changes Signed-off-by: Saad Khan <saakhan@redhat.com>
Contributor
Author
|
Updated now. This is how it looks now: Recommendation messages are moved to the log file and URLs are added in the log as well as in the README file for users to have easy access. |
Signed-off-by: Saad Khan <saakhan@redhat.com>
Signed-off-by: Saad Khan <saakhan@redhat.com>
Contributor
|
@khansaad Can you please do the below minor changes to have all the demos look similar.
#######################################
Success! Kafka Consumer took 20 seconds |
Signed-off-by: Saad Khan <saakhan@redhat.com>
Contributor
|
@kusumachalasani - Can you please close the review of this PR. |
Contributor
|
@khansaad The script abruptly ends without mentioning anything. But when I logged into log file it says Can you include the statement to look into the kafka-demo.log even when there are failures so user can know what would have happened. |
Contributor
|
@khansaad I'm trying to test it on new scalelab machine and I see the demo exits abruptly with the below issue. |
Contributor
Author
|
@kusumachalasani This issue is occuring due to the recent We can stick to |
Signed-off-by: Saad Khan <saakhan@redhat.com>
Contributor
Author
|
@kusumachalasani Please try this again now. Have updated the script now to use the latest |
Contributor
|
@khansaad |
Contributor
Author
@kusumachalasani Strimzi 0.46 requires following: for Strimzi 0.46.0: You need to update the version. I will update the same in the docs as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a demo script and related files to run the demo showcasing the working of Kafka consumer.
Note: This works on
openshiftcluster only for now.