Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing to ensure the book "builds" at all times #19

Open
mbrukman opened this issue Dec 22, 2017 · 2 comments
Open

Add testing to ensure the book "builds" at all times #19

mbrukman opened this issue Dec 22, 2017 · 2 comments

Comments

@mbrukman
Copy link
Contributor

The book is built using the script book/make-book.sh; however, syntax errors in the AsciiDoc file can break that build.

We should add a CI build (e.g., Travis) to test every PR and the master branch to ensure that it continues to build.

Proposal:

@krlawrence
Copy link
Owner

I like your proposal, this has been on my todo list. All the time it has been just me doing the writing it has not seemed like a big deal as I always do the build myself but I agree if others start to contribute text this will be very valuable.

@krlawrence
Copy link
Owner

Work is just getting started on a Second Edition. We can use this as a good excuse to revisit all kinds of automation possibilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants