chore: convention: bash variable names are lowercase

Author: kristof-mattei

.github/workflows/build.yml

@@ -43,8 +43,8 @@ jobs:
         shell: bash
         id: determine
         run: |
-          HAS_CONTAINER="${{ vars.HAS_CONTAINER }}"
-          echo "has_container=${HAS_CONTAINER:-false}" >> ${GITHUB_OUTPUT}
+          has_container="${{ vars.HAS_CONTAINER }}"
+          echo "has_container=${has_container:-false}" >> ${GITHUB_OUTPUT}
 
   changes:
     name: Detect changes
@@ -143,18 +143,18 @@ jobs:
         shell: bash
         id: version
         run: |
-          VERSION="$(cog bump --auto --dry-run || true)"
+          version="$(cog bump --auto --dry-run || true)"
 
-          if [[ "$VERSION" =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
-              echo "New version: ${VERSION}"
+          if [[ "$version" =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
+              echo "New version: ${version}"
           else
-              VERSION="v$(cog -v get-version)"
+              version="v$(cog -v get-version)"
 
-              echo "No version generated, defaulting to latest tag: ${VERSION}"
+              echo "No version generated, defaulting to latest tag: ${version}"
           fi
 
           # remove v
-          VERSION="${VERSION//v/}"
+          version="${version//v/}"
 
           # store
           echo "version=${VERSION}" >> ${GITHUB_OUTPUT}
@@ -522,8 +522,8 @@ jobs:
       - name: Set Docker tag
         shell: bash
         run: |
-          UNIQUE_TAG=pr-${{ github.event.pull_request.base.sha }}-${{ github.event.pull_request.head.sha }}
-          echo "UNIQUE_TAG=${UNIQUE_TAG##*/}" >> ${GITHUB_ENV}
+          unique_tag=pr-${{ github.event.pull_request.base.sha }}-${{ github.event.pull_request.head.sha }}
+          echo "UNIQUE_TAG=${unique_tag##*/}" >> ${GITHUB_ENV}
 
       # Extract metadata (tags, labels) for Docker
       # https://github.com/docker/metadata-action
@@ -548,8 +548,8 @@ jobs:
       - name: Set application name
         shell: bash
         run: |
-          APPLICATION_NAME=${{ github.repository }}
-          echo "APPLICATION_NAME=${APPLICATION_NAME##*/}" >> ${GITHUB_ENV}
+          application_name=${{ github.repository }}
+          echo "APPLICATION_NAME=${application_name##*/}" >> ${GITHUB_ENV}
 
       - name: Build Docker image
         uses: docker/build-push-action@1dc73863535b631f98b2378be8619f83b136f4a0 # v6.17.0
@@ -614,14 +614,14 @@ jobs:
       - name: Set application name
         shell: bash
         run: |
-          APPLICATION_NAME=${{ github.repository }}
-          echo "APPLICATION_NAME=${APPLICATION_NAME##*/}" >> ${GITHUB_ENV}
+          application_name=${{ github.repository }}
+          echo "APPLICATION_NAME=${application_name##*/}" >> ${GITHUB_ENV}
 
       - name: Set Docker tag (which is also the filename.tar)
         shell: bash
         run: |
-          UNIQUE_TAG=pr-${{ github.event.pull_request.base.sha }}-${{ github.event.pull_request.head.sha }}
-          echo "UNIQUE_TAG=${UNIQUE_TAG##*/}" >> ${GITHUB_ENV}
+          unique_tag=pr-${{ github.event.pull_request.base.sha }}-${{ github.event.pull_request.head.sha }}
+          echo "UNIQUE_TAG=${unique_tag##*/}" >> ${GITHUB_ENV}
 
       - name: Extract Docker metadata
         uses: docker/metadata-action@902fa8ec7d6ecbf8d84d538b9b233a880e428804 # v5.7.0

.github/workflows/publish-crate-after-release.yml

@@ -26,8 +26,8 @@ jobs:
         id: determine
         shell: bash
         run: |
-          HAS_CRATE="${{ vars.HAS_CRATE }}"
-          echo "has_crate=${HAS_CRATE:-false}" >> ${GITHUB_OUTPUT}
+          has_crate="${{ vars.HAS_CRATE }}"
+          echo "has_crate=${has_crate:-false}" >> ${GITHUB_OUTPUT}
 
   publish-crate:
     name: Publish crate
@@ -81,12 +81,12 @@ jobs:
         shell: bash
         id: version
         run: |
-          VERSION="${{ github.ref_name }}"
+          version="${{ github.ref_name }}"
           # remove v
-          VERSION="${VERSION//v/}"
+          version="${version//v/}"
 
           # store
-          cargo set-version ${VERSION}
+          cargo set-version ${version}
 
           # debug
           cat Cargo.toml

.github/workflows/retag-containers-after-push.yml

@@ -43,8 +43,8 @@ jobs:
         id: determine
         shell: bash
         run: |
-          HAS_CONTAINER="${{ vars.HAS_CONTAINER }}"
-          echo "has_container=${HAS_CONTAINER:-false}" >> ${GITHUB_OUTPUT}
+          has_container="${{ vars.HAS_CONTAINER }}"
+          echo "has_container=${has_container:-false}" >> ${GITHUB_OUTPUT}
 
   retag-containers:
     name: Retag the containers
@@ -67,12 +67,12 @@ jobs:
           # a commit always has a parent, but if it has 2, the commit is a merge
           # so lets see if we have one
           # since we're listening to the push event we have to do this manually
-          PARENT2=$(git rev-parse "HEAD^2" --quiet 2>/dev/null) || EXIT_CODE=$?
+          parent2=$(git rev-parse "HEAD^2" --quiet 2>/dev/null) || EXIT_CODE=$?
 
           if [ ${EXIT_CODE} -eq 0 ]
           then
-            echo "The head of the incoming PR is ${PARENT2}"
-            echo "INCOMING_PR_HEAD_COMMIT=${PARENT2}" >> ${GITHUB_ENV}
+            echo "The head of the incoming PR is ${parent2}"
+            echo "INCOMING_PR_HEAD_COMMIT=${parent2}" >> ${GITHUB_ENV}
 
           else
             echo "The incoming push isn't a merge, ergo it's not a PR"

.github/workflows/retag-containers-after-release.yml

@@ -31,8 +31,8 @@ jobs:
         id: determine
         shell: bash
         run: |
-          HAS_CONTAINER="${{ vars.HAS_CONTAINER }}"
-          echo "has_container=${HAS_CONTAINER:-false}" >> ${GITHUB_OUTPUT}
+          has_container="${{ vars.HAS_CONTAINER }}"
+          echo "has_container=${has_container:-false}" >> ${GITHUB_OUTPUT}
 
   retag-containers:
     name: Retag the containers

.github/workflows/test-release.yml

@@ -95,12 +95,12 @@ jobs:
 
           cog bump --auto
 
-          VERSION="v$(cog -v get-version)"
-          echo "version=$VERSION" >> $GITHUB_OUTPUT
+          version="v$(cog -v get-version)"
+          echo "version=${version}" >> ${GITHUB_OUTPUT}
 
-          cog changelog --at ${VERSION} > GITHUB_CHANGELOG.md
+          cog changelog --at ${version} > GITHUB_CHANGELOG.md
 
-          echo "New version: ${VERSION}"
+          echo "New version: ${version}"
 
           echo "Changelog: "