chore: group variables in single step

Author: kristof-mattei

.github/workflows/build.yml

@@ -456,11 +456,10 @@ jobs:
           - "ubuntu-latest"
           - "ubuntu-24.04-arm"
     outputs:
-      application_name: ${{ steps.application_name.outputs.application_name }}
-      image_name: ${{ steps.image_name.outputs.image_name }}
-      full_image_name: ${{ steps.full_image_name.outputs.full_image_name }}
-      registry: ${{ steps.registry.outputs.registry }}
-      unique_tag: ${{ steps.unique_tag.outputs.unique_tag }}
+      application_name: ${{ steps.variables.outputs.application_name }}
+      full_image_name: ${{ steps.variables.outputs.full_image_name }}
+      registry: ${{ steps.variables.outputs.registry }}
+      unique_tag: ${{ steps.variables.outputs.unique_tag }}
     runs-on: ${{ matrix.runs-on }}
     needs:
       - calculate-version
@@ -517,84 +516,75 @@ jobs:
 
       # TODO validate no changes between github.event.pull_request.head.sha and the actual current sha (representing the hypothetical merge)
 
-      - name: Lowercase the image name
+      - name: Set variables
         shell: bash
-        id: image_name
-        run: |
-          echo "image_name=${IMAGE_NAME,,}" >> ${GITHUB_OUTPUT}
-
-      - name: Set Docker tag
-        shell: bash
-        id: unique_tag
+        id: variables
         run: |
+          # This is the unique docker tag
           unique_tag=pr-${{ github.event.pull_request.base.sha }}-${{ github.event.pull_request.head.sha }}
-          echo "unique_tag=${unique_tag##*/}" >> ${GITHUB_OUTPUT}
+          echo "unique_tag=${unique_tag}" >> ${GITHUB_OUTPUT}
 
-      - name: Set application name
-        shell: bash
-        id: application_name
-        run: |
-          application_name=${{ github.repository }}
-          echo "application_name=${application_name##*/}" >> ${GITHUB_OUTPUT}
+          # The application name, used in the Dockerfile
+          application_name=${{ env.IMAGE_NAME }}
+          # split at the last / and keep that (kristof-mattei/repo-name -> repo-name)
+          application_name=${application_name##*/}
+          # lowercase
+          application_name=${application_name,,}
+          echo "application_name=${application_name}" >> ${GITHUB_OUTPUT}
 
-      - name: Set registry
-        shell: bash
-        id: registry
-        run: |
+          # The registry to which we'll push
           registry=${{ env.REGISTRY }}
+          registry=${registry,,}
           echo "registry=${registry}" >> ${GITHUB_OUTPUT}
 
-      - name: Set full image name
-        shell: bash
-        id: full_image_name
-        run: |
-          registry=${{ steps.registry.outputs.registry }}
-          image_name=${{ steps.image_name.outputs.image_name }}
-          echo "full_image_name=${registry,,}/${image_name,,}" >> ${GITHUB_OUTPUT}
+          # The full image name, which is the registry, the owner and the repo name
+          image_name=${{ env.IMAGE_NAME }}
+          image_name=${image_name,,}
+          echo "full_image_name=${registry}/${image_name}" >> ${GITHUB_OUTPUT}
 
       # Extract metadata (tags, labels) for Docker
       # https://github.com/docker/metadata-action
       - name: Extract Docker metadata
         uses: docker/metadata-action@902fa8ec7d6ecbf8d84d538b9b233a880e428804 # v5.7.0
         id: meta
         with:
-          images: ${{ steps.full_image_name.outputs.full_image_name }}
-          tags: |
-            type=raw,value=${{ steps.unique_tag.outputs.unique_tag }}
           labels: |
             org.opencontainers.image.version=pr-${{ github.event.number }}
             org.opencontainers.image.source=${{ github.event.pull_request.html_url }}
+          images: ${{ steps.variables.outputs.full_image_name }}
+          tags: |
+            type=raw,value=${{ steps.variables.outputs.unique_tag }}
 
-      - name: Log into registry ${{ steps.registry.outputs.registry }}
+      - name: Log into registry ${{ steps.variables.outputs.registry }}
         uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
         with:
-          registry: ${{ steps.registry.outputs.registry }}
-          username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
+          registry: ${{ steps.variables.outputs.registry }}
+          username: ${{ github.actor }}
 
       - name: Build Docker image
         uses: docker/build-push-action@1dc73863535b631f98b2378be8619f83b136f4a0 # v6.17.0
         with:
           build-args: |
-            APPLICATION_NAME=${{ steps.application_name.outputs.application_name }}
+            APPLICATION_NAME=${{ steps.variables.outputs.application_name }}
           context: .
           # this container is THE PR's artifact, and we will re-tag it
           # once the PR has been accepted
-          tags: ${{ steps.meta.outputs.tags }}
+          cache-from: type=registry,ref=${{ steps.variables.outputs.full_image_name }}:buildcache-${{ steps.variables.outputs.application_name }}
+          cache-to: type=registry,ref=${{ steps.variables.outputs.full_image_name }}:buildcache-${{ steps.variables.outputs.application_name }},mode=max
           labels: ${{ steps.meta.outputs.labels }}
-          cache-from: type=registry,ref=${{ steps.full_image_name.outputs.full_image_name }}:buildcache-${{ steps.application_name.outputs.application_name }}
-          cache-to: type=registry,ref=${{ steps.full_image_name.outputs.full_image_name }}:buildcache-${{ steps.application_name.outputs.application_name }},mode=max
+          outputs: type=oci,dest=/tmp/${{ steps.variables.outputs.unique_tag }}.tar
           platforms: linux/amd64, linux/arm64
-          outputs: type=oci,dest=/tmp/${{ steps.unique_tag.outputs.unique_tag }}.tar
+          tags: ${{ steps.meta.outputs.tags }}
 
       - name: Upload artifact
         uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
         if: |
           matrix.runs-on == 'ubuntu-latest'
         with:
-          name: container-${{ steps.application_name.outputs.application_name }}
-          path: /tmp/${{ steps.unique_tag.outputs.unique_tag }}.tar
           if-no-files-found: error
+          name: container-${{ steps.variables.outputs.application_name }}
+          path: /tmp/${{ steps.variables.outputs.unique_tag }}.tar
           retention-days: 1
 
   docker-publish: