Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for multiple $ref parameters doesn't work #73

Open
shattar opened this issue Dec 6, 2016 · 2 comments
Open

Validation for multiple $ref parameters doesn't work #73

shattar opened this issue Dec 6, 2016 · 2 comments

Comments

@shattar
Copy link

shattar commented Dec 6, 2016

Prior to making the parameter validators, an object is created where the object property keys are built from the parameters in and name properties. However, these properties are not existent on $ref parameters and, since $ref parameters are resolved after making this object, all of the $ref parameters get conflicting keys.

Also, the keys of this object are not even used, so there doesn't seem to be any point to it all. Maybe the point of it is so that def.parameters get overridden by operation.parameters. However, this is coming at the expense of $ref parameters not being validated.

@shattar
Copy link
Author

shattar commented Dec 6, 2016

#65 would solve this.

@djMax
Copy link

djMax commented May 1, 2020

Wow, what a horrific bug to exist for so long... Maybe it's a stretch to call it a security hole, but close. No validation occurs on these endpoints as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants