Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add adjacency neighbourhood #195

Conversation

RaczeQ
Copy link
Collaborator

@RaczeQ RaczeQ commented Mar 6, 2023

No description provided.

@RaczeQ RaczeQ linked an issue Mar 6, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #195 (8b9859d) into main (4da1270) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   98.99%   99.26%   +0.27%     
==========================================
  Files          33       34       +1     
  Lines         794      820      +26     
==========================================
+ Hits          786      814      +28     
+ Misses          8        6       -2     
Flag Coverage Δ
macos-latest-python3.10 99.26% <100.00%> (+0.27%) ⬆️
ubuntu-latest-python3.10 99.14% <100.00%> (+0.27%) ⬆️
ubuntu-latest-python3.8 99.14% <100.00%> (+0.28%) ⬆️
ubuntu-latest-python3.9 99.14% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/neighbourhoods/_base.py 100.00% <ø> (ø)
srai/neighbourhoods/__init__.py 100.00% <100.00%> (ø)
srai/neighbourhoods/adjacency_neighbourhood.py 100.00% <100.00%> (ø)
srai/neighbourhoods/h3_neighbourhood.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RaczeQ RaczeQ marked this pull request as ready for review March 9, 2023 22:41
piotrgramacki
piotrgramacki previously approved these changes Mar 9, 2023
Copy link
Collaborator

@piotrgramacki piotrgramacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@RaczeQ RaczeQ merged commit 0ad9954 into main Mar 10, 2023
@RaczeQ RaczeQ deleted the 191-implement-neighbourhood-working-for-any-geodataframe-with-regions branch March 10, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Neighbourhood working for any geodataframe with regions
2 participants