Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollouts: RSync naming schemes leads to failure for long git repo/org names. #3854

Open
droot opened this issue Mar 2, 2023 · 1 comment
Open

rollouts: RSync naming schemes leads to failure for long git repo/org names. #3854

droot opened this issue Mar 2, 2023 · 1 comment
Assignees
@droot
Labels
area/rollout bug Something isn't working p2 triaged Issue has been triaged by adding an `area/` label

Comments

@droot
Copy link
Contributor

droot commented Mar 2, 2023

Current implementation allows RSync names to be arbitrarily long (uses org/repo-name of the git repo) that fails whenever it hits the name limit. The task is to come up with a better naming scheme (probably using -<SHA(pkg attributes)>)
@droot droot added bug Something isn't working area/rollout labels Mar 2, 2023
@droot droot self-assigned this Mar 2, 2023
@droot droot added the triaged Issue has been triaged by adding an `area/` label label Mar 2, 2023
@droot
Copy link
Contributor Author

droot commented Mar 8, 2023

As part of this change #3853, remote-sync don't use orgname/repo-name, instead they use the prefix <gitlab|github>-<repo-id|project-id>-<dir-name>. So this should mitigate the problem to some extent. Though long nested directory paths can still lead to this problem.

But lowering the priority.

@droot droot added the p2 label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droot droot

Labels
area/rollout bug Something isn't working p2 triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@droot