set-namespace should not modify CustomResourceDefinition if spec.conversion.strategy is unset.

[yuwenma]

Expected behavior

Run gcr.io/kpt-fn/set-namespace:unstable against CustomResourceDefinition resource, we expect the spec.conversion.webhook.clientConfig.service.namespace to only be updated if the conversion.strategy is "webhook" (required)

Actual behavior

No matter what the strategy is, set-ns always update the webhook.clientConfig.service.namespace

[johnbelamaric]

Isn't this a duplicate of #3560 ? (which should say set-namespace in the title, which may be why it got duped...)

[yuwenma]

Isn't this a duplicate of #3560 ? (which should say set-namespace in the title, which may be why it got duped...)

Ah, Yes! I was in the impression of seeing such a bug report but really can't find it so I decide to file it myself.

[shashidhar-patil]

Is there a fix for it ?