Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kpt-functions-catalog CI broken due to the Kpt/WASM dependency #3507

Open
yuwenma opened this issue Aug 26, 2022 · 0 comments
Open

kpt-functions-catalog CI broken due to the Kpt/WASM dependency #3507

yuwenma opened this issue Aug 26, 2022 · 0 comments
Labels
area/devops area/fn-catalog Functions Catalog bug Something isn't working triaged Issue has been triaged by adding an `area/` label

Comments

@yuwenma
Copy link
Contributor

yuwenma commented Aug 26, 2022

The github CI is broken due to the WASM dependency introduced from Kpt. This affects all new checkins to the catalog repo.

Error build log: https://github.com/GoogleContainerTools/kpt-functions-catalog/runs/8026401841?check_suite_focus=true

Temporary workaround: https://github.com/GoogleContainerTools/kpt-functions-catalog/pull/906/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133ddR101

Long term solution: Ideally, kpt should have a CI (in https://github.com/GoogleContainerTools/kpt) to run against all catalog functions to verify that any kpt change is compatible with the curated KRM functions. Besides, the catalog repo should run each e2e test against the most recently released kpt, from downloading the binary rather than building the kpt. This guarantees the catalog and Kpt can have different go modules and won't affect each other.

Short term solution: WASM requires Go 1.18 and above. To specifically fix the WASM dependencies on the catalog repo, we can upgrade the catalog functions Go to v1.18

@yuwenma yuwenma added the bug Something isn't working label Aug 26, 2022
@mortent mortent added area/fn-catalog Functions Catalog triaged Issue has been triaged by adding an `area/` label area/devops labels Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devops area/fn-catalog Functions Catalog bug Something isn't working triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Development

No branches or pull requests

2 participants