Open
Conversation
mjholtkamp
force-pushed
the
feature/bugfix-pip20
branch
from
d22686d to
578d983
Compare
Apparently, the tests did not run since the testenv did not match, so the builds were green no matter the code. I changed the tox.ini and added py38-pip20 and made sure it failed before fixing the imports in pkgversion.py. On another note, we should probably not use internals like this because it will randomly break (like now). Fixing it now so we are unblocked at least.
mjholtkamp
force-pushed
the
feature/bugfix-pip20
branch
from
578d983 to
d681ee4
Compare
ricardosantosalves
approved these changes
Apr 6, 2020
Contributor
|
The same problem was acknowledged in #15 |
kammala
suggested changes
Apr 8, 2020
| 'Programming Language :: Python :: 2.7', | ||
| 'Programming Language :: Python :: 3', | ||
| 'Programming Language :: Python :: 3.5', | ||
| 'Programming Language :: Python :: 3.7', |
Contributor
There was a problem hiding this comment.
Should we also add python 3.6?
Contributor
There was a problem hiding this comment.
also it does not seem as FIX to me as we are officially dropping support for python version and adding support for next one. more like NEW or even BREAK(even though it is only python classifiers which do not mean it won't work with other versions)
| py36-{pip9,pip10}: python3.6 | ||
| cov: python3.6 | ||
| py27: python2.7 | ||
| py37: python3.7 |
Contributor
There was a problem hiding this comment.
I would also keep py36 here as it is the main platform for this package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, the tests did not run since the
testenv did not match, so the builds were green
no matter the code.
I changed the tox.ini and added py38-pip20 and
made sure it failed before fixing the imports
in pkgversion.py.
On another note, we should probably not use
internals like this because it will randomly
break (like now). Fixing it now so we are
unblocked at least.