Eliminated all clang warnings.

Author: Kasper Peeters

gui/window.cc

@@ -488,7 +488,8 @@ VisualCell *NotebookCanvas::add_cell(Glib::RefPtr<DataCell> dc, Glib::RefPtr<Dat
 			std::ostringstream fstr;
 			fstr << THEFONT << " " << 12+(doc.font_step*2); 
 			newcell->inbox=manage( new ExpressionInput(dc->textbuf, fstr.str()) );
-			Gtk::VBox::BoxList::iterator newit=bl.insert(gtkit, *newcell->inbox);
+//			Gtk::VBox::BoxList::iterator newit=
+			bl.insert(gtkit, *newcell->inbox);
 
 			gtk_box_set_child_packing(((Gtk::Box *)(&scrollbox))->gobj(), 
 											  ((Gtk::Widget *)(newcell->inbox))->gobj(),
@@ -517,7 +518,8 @@ VisualCell *NotebookCanvas::add_cell(Glib::RefPtr<DataCell> dc, Glib::RefPtr<Dat
 		case DataCell::c_texcomment:
 		case DataCell::c_comment: {
 			newcell->outbox=manage( new TeXView(dc->texbuf) );
-			Gtk::VBox::BoxList::iterator newit=bl.insert(gtkit, *newcell->outbox);
+//			Gtk::VBox::BoxList::iterator newit=
+			bl.insert(gtkit, *newcell->outbox);
          // REPORT BUG: this sometimes segfaults
          //			(*newit).set_options(Gtk::PACK_SHRINK);
 			gtk_box_set_child_packing(((Gtk::Box *)(&scrollbox))->gobj(), 
@@ -542,7 +544,8 @@ VisualCell *NotebookCanvas::add_cell(Glib::RefPtr<DataCell> dc, Glib::RefPtr<Dat
 				sigc::bind(
 					sigc::mem_fun(doc, &XCadabra::handle_tex_update_request), this, newcell));
 
-			Gtk::VBox::BoxList::iterator newit=bl.insert(gtkit, *newcell->texbox);
+//			Gtk::VBox::BoxList::iterator newit=
+			bl.insert(gtkit, *newcell->texbox);
 
 			gtk_box_set_child_packing(((Gtk::Box *)(&scrollbox))->gobj(), 
 											  ((Gtk::Widget *)(newcell->texbox))->gobj(),
@@ -1593,7 +1596,8 @@ Glib::RefPtr<DataCell> XCadabra::add_cell(Glib::RefPtr<DataCell> newcell, Glib::
 			}
 		}
 
-	Gtk::Allocation al=get_allocation();
+//	Gtk::Allocation al=
+	get_allocation();
 
 	try {
 		switch(newcell->cell_type) {
@@ -3284,7 +3288,7 @@ std::string XCadabra::load_config()
 			  if(rl.size()>0 && rl[0]=='#')
 					continue;
 
-			  unsigned int pos=rl.find(":=");
+			  size_t pos=rl.find(":=");
 			  if(pos==std::string::npos) {
 					str << "Error parsing ~/.xcadabra on line " << line << std::endl;
 					return str.str();

src/algorithm.cc

@@ -713,7 +713,7 @@ void algorithm::pushup_multiplier(iterator it)
 //			txtout << "PUSHUP: " << *it->name << std::endl;
 			if(tr.is_valid(tr.parent(it))) {
 //				txtout << "test propinherit" << std::endl;
-				iterator tmp=tr.parent(it);
+//				iterator tmp=tr.parent(it);
 				// tmp not always valid?!? This one crashes hard with a loop!?!
 //				txtout << " of " << *tmp->name << std::endl;
 				const PropertyInherit *pin=properties::get<PropertyInherit>(tr.parent(it));
@@ -823,7 +823,7 @@ bool algorithm::check_consistency(iterator it) const
 	w1.start();
 	debugout << "checking consistency ... " << std::flush;
 	assert(*it->name=="\\expression");
-	iterator entry=it;
+//	iterator entry=it;
 	iterator end=it;
 	end.skip_children();
 	++end;

src/manipulator.cc

@@ -283,7 +283,7 @@ bool manipulator::getline_precut(std::istream& str, std::string& buf)
 	if(getline_precut_buffer.size()==0 || getline_was_eof) {
 		std::string input_now;
 		getline_was_eof=false;
-		if(std::getline(str, input_now)==false)
+		if(!std::getline(str, input_now))
 			return false;
 		getline_precut_buffer+=input_now;
 		}
@@ -770,7 +770,8 @@ nset_t::iterator manipulator::collect_labels_(exptree& tr, exptree::iterator it)
 			nset_t::iterator name=tr.child(sit,0)->name;
 			// insert a label
 			iterator lit=tr.insert(it, str_node("\\label", str_node::b_no));
-			iterator nameit=tr.append_child(lit, str_node(*name, str_node::b_none));
+//			iterator nameit=
+			tr.append_child(lit, str_node(*name, str_node::b_none));
 			// remove the declare node
 			tr.flatten(sit);
 			sit=tr.erase(sit);
@@ -1142,7 +1143,8 @@ exptree::iterator manipulator::run_procedure(exptree::iterator proc, long collec
 			collectcount=0;
 			collected=true;
 			txtout << "collecting terms; of " << expressions.number_of_children(act) << " terms ";
-			sibling_iterator from(expressions.begin(act)), to(sib);
+//			sibling_iterator from(expressions.begin(act)),
+			sibling_iterator to(sib);
 			collector.apply(act);
 //			collector.apply(from, to);
 			txtout << expressions.number_of_children(act) << " remain." << std::endl;

src/modules/algebra.cc

@@ -1303,7 +1303,7 @@ bool sumsort::should_swap(iterator obj, int subtree_comparison) const
 
 
 prodsort::prodsort(exptree& tr, iterator it)
-	: algorithm(tr, it), ignore_numbers_(false)
+	: algorithm(tr, it) //, ignore_numbers_(false)
 	{
 //	if(has_argument("IgnoreNumbers")) {
 //		txtout << "ignoring numbers" << std::endl;
@@ -3241,6 +3241,8 @@ algorithm::result_t canonicalise::apply(iterator& it)
 //				num_to_tree_map.push_back(exptree(i2->first));
 //				num_to_tree_map.push_back(exptree(ii->first));
 				break;
+			default:
+				break;
 			}
 
 		vec_perm.push_back(ii->second+1);

src/modules/algebra.hh

@@ -287,7 +287,7 @@ class prodsort : public algorithm {
 		virtual result_t apply(iterator&);
 
 	private:
-		bool ignore_numbers_;
+//		bool ignore_numbers_;
 };
 
 class spinorsort : public algorithm {

src/modules/substitute.cc

@@ -24,7 +24,7 @@
 #include "dummies.hh"
 
 substitute::substitute(exptree& tr, iterator it)
-	: algorithm(tr, it), start_reporting_outside(false), prodsort_(tr, it)
+	: algorithm(tr, it), prodsort_(tr, it) // start_reporting_outside(false), 
 	{
 	if(number_of_args()==0) {
 		txtout << "substitute: need (list of) replacement rules." << std::endl;
@@ -535,7 +535,8 @@ algorithm::result_t vary::apply(iterator& it)
 				if(fcit2->is_zero()==false && res==algorithm::l_applied) {
 					expression_modified=true;
 //					txtout << "new term\n";
-					iterator newterm=result.append_child(newsum, it);
+//					iterator newterm=
+					result.append_child(newsum, it);
 					}
 
 				// restore original

src/modules/substitute.hh

@@ -48,7 +48,7 @@ class substitute : public algorithm {
 		std::vector<bool>  lhs_contains_dummies, rhs_contains_dummies;
 
 		stopwatch tmr;
-		bool start_reporting_outside;
+//		bool start_reporting_outside;
 
 		// For object swap testing routines:
 		prodsort    prodsort_;

src/modules/tableaux.cc

@@ -535,7 +535,7 @@ algorithm::result_t young_project_product::apply(iterator& it)
 					// Distribute this projected factor over all existing terms in rep,
 					sibling_iterator trm=rep.begin(topsum);
 					while(trm!=rep.end(topsum)) {
-						 iterator tmp=trm;
+//						 iterator tmp=trm;
 						 sibling_iterator nxttrm=trm;
 						 ++nxttrm;
 

src/tree_regression_tests.cc

@@ -87,7 +87,8 @@ int test2()
 	h1  =tr.append_child(body, "h1");
 	bh1 =tr.insert(h1,"before h1");
 	sometext = tr.append_child(h1, "some text");
-	tree<std::string>::sibling_iterator more_text=tr.append_child(body, "more text");
+//	tree<std::string>::sibling_iterator more_text=
+	tr.append_child(body, "more text");
 
 	res*=compare_tree("basic algorithms", tr, "extra\nhtml(body(before h1, h1(some text), more text))");