Skip to content

Commit 85a5777

Browse files
author
Jon Ludlam
committed
Use syslog from xcp
Signed-off-by: Jon Ludlam <jonathan.ludlam@eu.citrix.com>
1 parent bbb4b15 commit 85a5777

File tree

6 files changed

+7
-71
lines changed

6 files changed

+7
-71
lines changed

_oasis

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Library xenopsd
3232
Path: lib
3333
Findlibname: xenopsd
3434
Modules: Cancellable_subprocess, Bootloader, Ionice, Mac, Xenops_migrate, Xenops_hooks, Task_server, Xenops_task, Updates, Xenops_utils, Xenops_server, Xenopsd, Xenops_server_plugin, Xenops_server_skeleton, Scheduler, Path, Storage, Interface
35-
BuildDepends: syslog, threads, threads.posix, uuidm, xmlm, cohttp, uri, rpclib, rpclib.syntax, forkexec, fd-send-recv, xcp, xcp.xen, xcp.storage, rpclib.syntax, sexplib, xcp
35+
BuildDepends: threads, threads.posix, uuidm, xmlm, cohttp, uri, rpclib, rpclib.syntax, forkexec, fd-send-recv, xcp, xcp.xen, xcp.storage, rpclib.syntax, sexplib, xcp
3636

3737
Executable xenguest
3838
CompiledObject: best

_tags

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# OASIS_START
2-
# DO NOT EDIT (digest: 6adfdcd89fb0d753f9b9b283e10815f6)
2+
# DO NOT EDIT (digest: 5c2e2b7e36393ffd36642a4bdd4bbefa)
33
# Ignore VCS directories, you can use the same kind of rule outside
44
# OASIS_START/STOP if you want to exclude directories that contains
55
# useless stuff for the build process
@@ -20,7 +20,6 @@
2020
<lib/*.ml{,i}>: pkg_xcp
2121
<lib/*.ml{,i}>: pkg_xcp.storage
2222
<lib/*.ml{,i}>: pkg_sexplib
23-
<lib/*.ml{,i}>: pkg_syslog
2423
<lib/*.ml{,i}>: pkg_threads
2524
<lib/*.ml{,i}>: pkg_threads.posix
2625
<lib/*.ml{,i}>: pkg_uuidm
@@ -51,7 +50,6 @@
5150
<xc/xenops_xc_main.{native,byte}>: pkg_xcp.memory
5251
<xc/xenops_xc_main.{native,byte}>: pkg_sexplib
5352
<xc/xenops_xc_main.{native,byte}>: pkg_xcp-inventory
54-
<xc/xenops_xc_main.{native,byte}>: pkg_syslog
5553
<xc/xenops_xc_main.{native,byte}>: pkg_threads
5654
<xc/xenops_xc_main.{native,byte}>: pkg_threads.posix
5755
<xc/xenops_xc_main.{native,byte}>: pkg_uuidm
@@ -74,7 +72,6 @@
7472
<xc/*.ml{,i}>: pkg_xcp.memory
7573
<xc/*.ml{,i}>: pkg_sexplib
7674
<xc/*.ml{,i}>: pkg_xcp-inventory
77-
<xc/*.ml{,i}>: pkg_syslog
7875
<xc/*.ml{,i}>: pkg_threads
7976
<xc/*.ml{,i}>: pkg_threads.posix
8077
<xc/*.ml{,i}>: pkg_uuidm
@@ -97,7 +94,6 @@
9794
"xc/fsync_stubs.c": pkg_xcp.memory
9895
"xc/fsync_stubs.c": pkg_sexplib
9996
"xc/fsync_stubs.c": pkg_xcp-inventory
100-
"xc/fsync_stubs.c": pkg_syslog
10197
"xc/fsync_stubs.c": pkg_threads
10298
"xc/fsync_stubs.c": pkg_threads.posix
10399
"xc/fsync_stubs.c": pkg_uuidm
@@ -120,7 +116,6 @@
120116
"xc/xenctrlext_stubs.c": pkg_xcp.memory
121117
"xc/xenctrlext_stubs.c": pkg_sexplib
122118
"xc/xenctrlext_stubs.c": pkg_xcp-inventory
123-
"xc/xenctrlext_stubs.c": pkg_syslog
124119
"xc/xenctrlext_stubs.c": pkg_threads
125120
"xc/xenctrlext_stubs.c": pkg_threads.posix
126121
"xc/xenctrlext_stubs.c": pkg_uuidm
@@ -138,7 +133,6 @@
138133
<simulator/xenops_simulator_main.{native,byte}>: pkg_xcp
139134
<simulator/xenops_simulator_main.{native,byte}>: pkg_xcp.storage
140135
<simulator/xenops_simulator_main.{native,byte}>: pkg_sexplib
141-
<simulator/xenops_simulator_main.{native,byte}>: pkg_syslog
142136
<simulator/xenops_simulator_main.{native,byte}>: pkg_threads
143137
<simulator/xenops_simulator_main.{native,byte}>: pkg_threads.posix
144138
<simulator/xenops_simulator_main.{native,byte}>: pkg_uuidm
@@ -154,7 +148,6 @@
154148
<simulator/*.ml{,i}>: pkg_xcp
155149
<simulator/*.ml{,i}>: pkg_xcp.storage
156150
<simulator/*.ml{,i}>: pkg_sexplib
157-
<simulator/*.ml{,i}>: pkg_syslog
158151
<simulator/*.ml{,i}>: pkg_threads
159152
<simulator/*.ml{,i}>: pkg_threads.posix
160153
<simulator/*.ml{,i}>: pkg_uuidm
@@ -173,7 +166,6 @@
173166
<libvirt/xenops_libvirt_main.{native,byte}>: pkg_xcp.storage
174167
<libvirt/xenops_libvirt_main.{native,byte}>: pkg_sexplib
175168
<libvirt/xenops_libvirt_main.{native,byte}>: pkg_libvirt
176-
<libvirt/xenops_libvirt_main.{native,byte}>: pkg_syslog
177169
<libvirt/xenops_libvirt_main.{native,byte}>: pkg_threads
178170
<libvirt/xenops_libvirt_main.{native,byte}>: pkg_threads.posix
179171
<libvirt/xenops_libvirt_main.{native,byte}>: pkg_uuidm
@@ -190,7 +182,6 @@
190182
<libvirt/*.ml{,i}>: pkg_xcp.storage
191183
<libvirt/*.ml{,i}>: pkg_sexplib
192184
<libvirt/*.ml{,i}>: pkg_libvirt
193-
<libvirt/*.ml{,i}>: pkg_syslog
194185
<libvirt/*.ml{,i}>: pkg_threads
195186
<libvirt/*.ml{,i}>: pkg_threads.posix
196187
<libvirt/*.ml{,i}>: pkg_uuidm
@@ -218,7 +209,6 @@
218209
<xl/xenops_xl_main.{native,byte}>: pkg_xcp.memory
219210
<xl/xenops_xl_main.{native,byte}>: pkg_sexplib
220211
<xl/xenops_xl_main.{native,byte}>: pkg_xcp-inventory
221-
<xl/xenops_xl_main.{native,byte}>: pkg_syslog
222212
<xl/xenops_xl_main.{native,byte}>: pkg_threads
223213
<xl/xenops_xl_main.{native,byte}>: pkg_threads.posix
224214
<xl/xenops_xl_main.{native,byte}>: pkg_uuidm
@@ -243,7 +233,6 @@
243233
<xl/*.ml{,i}>: pkg_xcp.memory
244234
<xl/*.ml{,i}>: pkg_sexplib
245235
<xl/*.ml{,i}>: pkg_xcp-inventory
246-
<xl/*.ml{,i}>: pkg_syslog
247236
<xl/*.ml{,i}>: pkg_threads
248237
<xl/*.ml{,i}>: pkg_threads.posix
249238
<xl/*.ml{,i}>: pkg_uuidm
@@ -268,7 +257,6 @@
268257
"xl/fsync_stubs.c": pkg_xcp.memory
269258
"xl/fsync_stubs.c": pkg_sexplib
270259
"xl/fsync_stubs.c": pkg_xcp-inventory
271-
"xl/fsync_stubs.c": pkg_syslog
272260
"xl/fsync_stubs.c": pkg_threads
273261
"xl/fsync_stubs.c": pkg_threads.posix
274262
"xl/fsync_stubs.c": pkg_uuidm
@@ -293,7 +281,6 @@
293281
"xl/poll_stubs.c": pkg_xcp.memory
294282
"xl/poll_stubs.c": pkg_sexplib
295283
"xl/poll_stubs.c": pkg_xcp-inventory
296-
"xl/poll_stubs.c": pkg_syslog
297284
"xl/poll_stubs.c": pkg_threads
298285
"xl/poll_stubs.c": pkg_threads.posix
299286
"xl/poll_stubs.c": pkg_uuidm

lib/META

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# OASIS_START
2-
# DO NOT EDIT (digest: fe20234855dd68aa5129735f8475dde3)
2+
# DO NOT EDIT (digest: 05497db94fb93ddb7a6ea84dc7232c63)
33
version = "0.9.24"
44
description = "XenServer domain managers"
55
requires =
6-
"syslog threads threads.posix uuidm xmlm cohttp uri rpclib rpclib.syntax forkexec fd-send-recv xcp xcp.xen xcp.storage rpclib.syntax sexplib xcp"
6+
"threads threads.posix uuidm xmlm cohttp uri rpclib rpclib.syntax forkexec fd-send-recv xcp xcp.xen xcp.storage rpclib.syntax sexplib xcp"
77
archive(byte) = "xenopsd.cma"
88
archive(byte, plugin) = "xenopsd.cma"
99
archive(native) = "xenopsd.cmxa"

lib/xenops_utils.ml

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -16,54 +16,6 @@ open Xenops_interface
1616

1717
let ( |> ) a b = b a
1818

19-
module type BRAND = sig val name: string end
20-
21-
module Debug = struct
22-
type level =
23-
| Debug
24-
| Warn
25-
| Info
26-
| Error
27-
28-
let disabled_modules = ref []
29-
let disable m =
30-
disabled_modules := m :: !disabled_modules
31-
32-
let stderr key level x =
33-
output_string stderr (Printf.sprintf "[%s|%s] %s" key (match level with
34-
| Debug -> "debug"
35-
| Warn -> "warn"
36-
| Info -> "info"
37-
| Error -> "error") x);
38-
output_string stderr "\n";
39-
flush stderr
40-
41-
let syslog ?(facility=`LOG_LOCAL5) name () =
42-
let t = Syslog.openlog ~facility name in
43-
fun key level x ->
44-
Syslog.syslog t (match level with
45-
| Debug -> `LOG_DEBUG
46-
| Warn -> `LOG_WARNING
47-
| Info -> `LOG_INFO
48-
| Error -> `LOG_ERR
49-
) (Printf.sprintf "[%s] %s" key x)
50-
51-
let output = ref stderr
52-
53-
let write key level x =
54-
if not(List.mem key !disabled_modules)
55-
then !output key level x
56-
57-
let with_thread_associated _ f x = f x (* XXX *)
58-
59-
module Make = functor(Brand: BRAND) -> struct
60-
let debug fmt = Printf.ksprintf (write Brand.name Debug) fmt
61-
let error fmt = Printf.ksprintf (write Brand.name Error) fmt
62-
let info fmt = Printf.ksprintf (write Brand.name Info) fmt
63-
let warn fmt = Printf.ksprintf (write Brand.name Warn) fmt
64-
end
65-
end
66-
6719
module D = Debug.Make(struct let name = "xenops_utils" end)
6820
open D
6921

lib/xenopsd.ml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ let handle_received_fd this_connection =
8888

8989

9090
let main ?(specific_options=[]) ?(specific_essential_paths=[]) ?(specific_nonessential_paths=[]) backend =
91-
Debug.output := Debug.syslog (Filename.basename Sys.argv.(0)) ();
92-
9391
debug "xenopsd version %d.%d starting" major_version minor_version;
9492

9593
let options = options @ specific_options in

setup.ml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
(* setup.ml generated for the first time by OASIS v0.3.0 *)
22

33
(* OASIS_START *)
4-
(* DO NOT EDIT (digest: 4050686096419fab4143c6d367c5ef1f) *)
4+
(* DO NOT EDIT (digest: e37be906ef3d0135a19b8a37000afdb1) *)
55
(*
66
Regenerated by OASIS v0.3.0
77
Visit http://oasis.forge.ocamlcore.org for more information and
@@ -5697,7 +5697,6 @@ let setup_t =
56975697
bs_compiled_object = Best;
56985698
bs_build_depends =
56995699
[
5700-
FindlibPackage ("syslog", None);
57015700
FindlibPackage ("threads", None);
57025701
FindlibPackage ("threads.posix", None);
57035702
FindlibPackage ("uuidm", None);
@@ -5949,14 +5948,14 @@ let setup_t =
59495948
};
59505949
oasis_fn = Some "_oasis";
59515950
oasis_version = "0.3.0";
5952-
oasis_digest = Some "Z\160\249\140\016C>D\224\241\213p&\160PV";
5951+
oasis_digest = Some "\0014-a\191\218\156\157\1298\140^\140\251\030\222";
59535952
oasis_exec = None;
59545953
oasis_setup_args = [];
59555954
setup_update = false;
59565955
};;
59575956

59585957
let setup () = BaseSetup.setup setup_t;;
59595958

5960-
# 5961 "setup.ml"
5959+
# 5960 "setup.ml"
59615960
(* OASIS_STOP *)
59625961
let () = setup ();;

0 commit comments

Comments
 (0)