Skip to content

Commit 554251d

Browse files
committed
Fix all but 1 lint warnings
- Bring target sdk and build tools to current version
1 parent 75c4bbe commit 554251d

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

AndroidAsync/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@ android {
2222
}
2323

2424
defaultConfig {
25-
targetSdkVersion 24
25+
targetSdkVersion 25
2626
minSdkVersion 9
2727
}
2828

29-
compileSdkVersion 24
30-
buildToolsVersion '24.0.2'
29+
compileSdkVersion 25
30+
buildToolsVersion '24.0.3'
3131
}
3232

3333
// upload to maven task

AndroidAsync/lint.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<lint>
3-
</lint>
3+
<!-- Adding assertions into the codebase is intentional, so we can
4+
ignore this error -->
5+
<issue id="Assert" severity="ignore" />
6+
</lint>

AndroidAsync/src/com/koushikdutta/async/AsyncSSLSocketWrapper.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.koushikdutta.async;
22

3+
import android.annotation.SuppressLint;
34
import android.os.Build;
45

56
import com.koushikdutta.async.callback.CompletedCallback;
@@ -70,6 +71,8 @@ public java.security.cert.X509Certificate[] getAcceptedIssuers() {
7071
return new X509Certificate[0];
7172
}
7273

74+
// this TrustManager only applies a fix, the actual certificate chaine verification is done elsewhere
75+
@SuppressLint("TrustAllX509TrustManager")
7376
public void checkClientTrusted(java.security.cert.X509Certificate[] certs, String authType) {
7477
}
7578

0 commit comments

Comments
 (0)