Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Hooli-style-Popup #58

Merged
merged 6 commits into from
Aug 5, 2022
Merged

add Hooli-style-Popup #58

merged 6 commits into from
Aug 5, 2022

Conversation

ksalpern
Copy link
Contributor

@ksalpern ksalpern commented Aug 3, 2022

Hooli-style-Popup

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
Your PR should contain only files for review. Remove .map and .css files. For future PR's add only source code not compiled.)

submissions/ksalpern/Hooli-style-Popup/index.html Outdated Show resolved Hide resolved
submissions/ksalpern/Hooli-style-Popup/index.html Outdated Show resolved Hide resolved
submissions/ksalpern/Hooli-style-Popup/index.html Outdated Show resolved Hide resolved
submissions/ksalpern/Hooli-style-Popup/scss/style.scss Outdated Show resolved Hide resolved
submissions/ksalpern/Hooli-style-Popup/scss/style.scss Outdated Show resolved Hide resolved
submissions/ksalpern/Hooli-style-Popup/scss/style.scss Outdated Show resolved Hide resolved
@ksalpern ksalpern requested a review from A-Ostrovnyy August 3, 2022 20:43
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@ksalpern ksalpern requested a review from A-Ostrovnyy August 4, 2022 10:54
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ksalpern ksalpern requested a review from A-Ostrovnyy August 4, 2022 19:49
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you add some changes but I can't validate them because you forget to update your demo)

submissions/ksalpern/Hooli-style-Popup/scss/style.scss Outdated Show resolved Hide resolved
submissions/ksalpern/Hooli-style-Popup/index.html Outdated Show resolved Hide resolved
@ksalpern ksalpern requested a review from A-Ostrovnyy August 5, 2022 08:50
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small issues must be done)

@ksalpern ksalpern requested a review from A-Ostrovnyy August 5, 2022 12:44
justify-content: flex-end;
align-items: center;

.nav__items {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you forget to fix nesting here)
For this time I merge this PR but in future avoid mistakes like this)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright) Thanks for your time, I appreciate your efforts)

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

@A-Ostrovnyy A-Ostrovnyy merged commit 003e927 into kottans:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants