friends-app #56
friends-app #56
Conversation
|
|
|
|
ohh sorry, my bad its the old version of the code:( |
|
Kelly is still woman in the new code |
Hi! Already fixed^ |
|
Alex not a women :) Sorting by age |
ohh the problem is only in the link to the code and the demo |
pls review again^) thank you a lot |
|
If I will click on the search field, you will reset the filter state. Also, UX - I can't see what filters/sorters are selected. All buttons look the same, no matter were they are selected or not. |
okey, I will do it:) thanks ^^ |
1 similar comment
okey, I will do it:) thanks ^^ |
@zonzujiro |
|
@zonzujiro |
|
I see initial request but I don't see friends :( |
|
Ah, not on you I suppose |
|
Hey! Congratulations on your PR! 😎😎😎 Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code. Go through the requirements/most common mistakes linked below and fix the code as appropriate. If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat. When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly. Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒 Please, make sure you haven't made common mistakes. Universal recommendations:
By the way, you may proceed to the next task before this one is reviewed and merged. Sincerely yours, |
hmm, it works on my device |
| fetch(URL) | ||
| .then((response) => response.json()) | ||
| .then((users) => { | ||
| console.log("ok"); |
There was a problem hiding this comment.
You also should handle the error from http request. Pls check common mistakes in the message from bot
There was a problem hiding this comment.
Pls don't resolve discussions without taking any actions.
console.log is still there and it is still redundant
|
@zonzujiro check please) |
|
@zonzujiro friendly reminder |
You can also post a link to students chat and ask them to debug your application :) |
| alert("Please reload, Authorization failed : " + error.message); | ||
| console.log("Authorization failed : " + error.message); |
There was a problem hiding this comment.
alert is bit of too agressive, no? :)
There was a problem hiding this comment.
okey, what should I do?
There was a problem hiding this comment.
You can just render a message.
| const checkboxes = Array.from( | ||
| document.querySelectorAll(".gender_checkbox:checked") | ||
| ); | ||
| filteredUsers = friends.filter((item) => | ||
| checkboxes.some((gender) => item.gender === gender.value) | ||
| ); |
There was a problem hiding this comment.
Redundant logic. If both checkboxes are selected you actually don't need to run filtration. You just need to render the initial array.
|
@zonzujiro friendly reminder 🤗 |
|
This issue has been automatically marked as stale because there were no activity during last 14 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. А. Чому так? Б. Що робити, якщо в піарі нема оновлень, оскільки не зрозуміло, що треба зробити? В. А якщо я все зробив(ла) і це ментор не рев'юває мої зміни?
Г. Хіба недостатньо того, що я додав(ла) коміт із змінами? Традиційна пропозиція: задай питання по вищенаписаному в студентському чаті. |
friends-app
Demo |
Code base