Task "Task js oop" #499

DmitryHniezdilov · 2022-09-09T11:36:29Z

Object Oriented JS

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

github-actions · 2022-09-09T11:48:24Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements

Universal recommendations:

Make sure your code follows General Requirements
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

add: added configurate objects for characters.

DmitryHniezdilov · 2022-09-11T18:22:34Z

Hi. I update app.js file following the requirements. Interesting Your opinion about it.

Please, review.

DmitryHniezdilov · 2022-09-17T19:17:51Z

Hi. I tried refactoring with the base class, which is extended using prototype syntax.

Please, review.

naming isFreeze.

OleksiyRudenko

@DmitryHniezdilov quite a decent job.
A couple of important changes and we are done.

OleksiyRudenko · 2022-09-20T16:23:04Z

submissions/DmitryHniezdilov/task_js_oop/app.js

+    player.y === this.y &&
+    player.x <= Math.floor(this.x) + this.BLOCK_WIDTH / 1.3 &&
+    player.x >= Math.floor(this.x) - this.BLOCK_WIDTH / 1.3


The requirements address this case specifically.
Please find it, post here as a comment and fix code accordingly.
This is also applicable to other global variables with the exception of constants as described in the requirements.

Please find it, post here as a comment and fix code accordingly.

"Requirements regarding Constants:
i. All numbers like block dimensions, initial locations are defined as constants.";
ii. Every number that has a semantic purpose (like those listed above) should be defined as constants; think of how your code reads - the closer to plain English the better."

I missed adding this number as a constant in the config object. Done.

OleksiyRudenko · 2022-09-20T16:25:22Z

submissions/DmitryHniezdilov/task_js_oop/app.js

+Enemy.prototype.createEnemies = function (config) {
+  const { ENEMIES_CONF, STATE, ORIGIN_COORDINATE_CHARACTERS, BLOCK_HEIGHT } =


Looks like a factory pattern, but mixed with the class itself.
This could be a static method of the class. Otherwise it looks weird when we create an instance to create other instances.
If you are not sure of how to implement a static method in prototype syntax, just implement a global function outside class definition to create enemies.

In order not to change the game control function Character.prototype.endOfGame, I initialized a config object in Character and created a function EnemiesFactory, which inherits this and .prototype from Enemy. After initializing the EnemiesFactory, I was able to use the enemy control methods as static methods (enemiesFactory.createEnemies();).
I haven't found a better way to update this code.

DmitryHniezdilov · 2022-09-25T11:23:46Z

Hello. I tried to refactor this code on the prototype syntax. Thanks for the advice just implement global function outside class definition to create enemies. In this case it doesn't work. It was a good practice to understand OOP.

Please, review.

implemented a global function to create enemies; created class for restart game; added variable isFreeze to Character.

OleksiyRudenko

@DmitryHniezdilov very good job!
A couple of improvements and we are done.

OleksiyRudenko · 2022-09-26T12:06:51Z

submissions/DmitryHniezdilov/task_js_oop/app.js

+  !this.isFreeze &&
+    ((this.x += this.speed * dt),
+    this.x > this.FIELD_WIDTH && (this.x = -this.BLOCK_WIDTH),
+    this.checkCollision());


Valid syntax, yet not really readable.
Ol' good if would work better.

OleksiyRudenko · 2022-09-26T12:07:24Z

submissions/DmitryHniezdilov/task_js_oop/app.js

+    player.y === this.y &&
+    player.x <=
+      Math.floor(this.x) + this.BLOCK_WIDTH / this.ENEMIES_CONF.overlapRatio &&
+    player.x >=
+      Math.floor(this.x) - this.BLOCK_WIDTH / this.ENEMIES_CONF.overlapRatio;
+


See item 4.iii of the requirements

OleksiyRudenko

@DmitryHniezdilov great job done!

DmitryHniezdilov · 2022-09-26T19:49:47Z

Thank you!

add files for task_js_oop

829256a

OleksiyRudenko added the task-Frogger label Sep 9, 2022

fix: change naming, calculations, createEnemies();

429ce58

add: added configurate objects for characters.

fix: tried refactoring with requirements

7b240da

fix: change Enemy.startPositionOfEnemies,

2a24939

naming isFreeze.

OleksiyRudenko added the self-check-done Student confirmed that self-checks against requirements/common-mistakes are done label Sep 20, 2022

OleksiyRudenko requested changes Sep 20, 2022

View reviewed changes

OleksiyRudenko self-assigned this Sep 20, 2022

fix: changed after review

5af1cda

DmitryHniezdilov requested a review from OleksiyRudenko September 21, 2022 14:50

fix: added condition isCollision

40f7306

DmitryHniezdilov force-pushed the DmitryHniezdilov-task-js-oop branch from e466db7 to f7b3e0e Compare September 25, 2022 13:10

fix: refactored code

6b0e025

implemented a global function to create enemies; created class for restart game; added variable isFreeze to Character.

DmitryHniezdilov force-pushed the DmitryHniezdilov-task-js-oop branch from f7b3e0e to 6b0e025 Compare September 25, 2022 13:16

OleksiyRudenko requested changes Sep 26, 2022

View reviewed changes

fix: changes after review

eb0094f

DmitryHniezdilov requested a review from OleksiyRudenko September 26, 2022 16:38

OleksiyRudenko approved these changes Sep 26, 2022

View reviewed changes

OleksiyRudenko merged commit 3105d92 into kottans:main Sep 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Task "Task js oop" #499

Task "Task js oop" #499

DmitryHniezdilov commented Sep 9, 2022

github-actions bot commented Sep 9, 2022

DmitryHniezdilov commented Sep 11, 2022

DmitryHniezdilov commented Sep 17, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 20, 2022

DmitryHniezdilov Sep 21, 2022 •

edited

Loading

OleksiyRudenko Sep 20, 2022

DmitryHniezdilov Sep 21, 2022

DmitryHniezdilov commented Sep 25, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 26, 2022

DmitryHniezdilov Sep 26, 2022

OleksiyRudenko Sep 26, 2022

DmitryHniezdilov Sep 26, 2022

OleksiyRudenko left a comment

DmitryHniezdilov commented Sep 26, 2022

		Enemy.prototype.createEnemies = function (config) {
		const { ENEMIES_CONF, STATE, ORIGIN_COORDINATE_CHARACTERS, BLOCK_HEIGHT } =

Task "Task js oop" #499

Task "Task js oop" #499

Conversation

DmitryHniezdilov commented Sep 9, 2022

Object Oriented JS

github-actions bot commented Sep 9, 2022

DmitryHniezdilov commented Sep 11, 2022

DmitryHniezdilov commented Sep 17, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

OleksiyRudenko Sep 20, 2022

Choose a reason for hiding this comment

DmitryHniezdilov Sep 21, 2022 • edited Loading

Choose a reason for hiding this comment

OleksiyRudenko Sep 20, 2022

Choose a reason for hiding this comment

DmitryHniezdilov Sep 21, 2022

Choose a reason for hiding this comment

DmitryHniezdilov commented Sep 25, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

OleksiyRudenko Sep 26, 2022

Choose a reason for hiding this comment

DmitryHniezdilov Sep 26, 2022

Choose a reason for hiding this comment

OleksiyRudenko Sep 26, 2022

Choose a reason for hiding this comment

DmitryHniezdilov Sep 26, 2022

Choose a reason for hiding this comment

OleksiyRudenko left a comment

Choose a reason for hiding this comment

DmitryHniezdilov commented Sep 26, 2022

DmitryHniezdilov Sep 21, 2022 •

edited

Loading