A tiny JS world task

[deveLabR]

Building a Tiny JS World

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

A Tiny JS World -- (pre-OOP) exercise check list

Relates to Object-Oriented JavaScript task.

Check-list - definition of done

• Code is DRY, which means that whenever you see a pattern in your code those should be eliminated as much as possible. Examples:
  • print(dog); print(cat); etc ... should be refactored employing Array.forEach as the least
  • `${obj.legs}; ${obj.name}; etc...` (yes, strings are also code) must be refactored employing appropriate Array methods
• Object methods like keys, values, entries shouldn't be used when a particular order is required as these do not guarantee any particular order of keys/values. Same refers to for...of and for...in when applied to objects.
  Hint: List explicitly the properties used to form an object presentation string.
• Men and women belong to the same biological species.
• ES6 class or prototype-based OO syntax aren't used.

Universal recommendations:

• Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
• Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
• Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

[deveLabR]

Self-check done.

[OleksiyRudenko]

@deveLabR well done!
Let's polish it.

[OleksiyRudenko]

A classic use case for Array#map

[yaripey]

Hey, good job, you're almost there! Let's improve some things. Check the comments below.

[yaripey]

Let's make a better name for this variable. You almost never want to use the data type in the name of the variable, it is an indicator that the name is not descriptive enough. Maybe something like personInfoItems?

[yaripey]

Let's use attributes here. Plural implies that this is an array and not just one attribute and helps readability.

[yaripey]

Array method map() creates a new array of elements that are returned from each callback function that is called for each element of the initial array. You don't need to create a separate empty array before and push it there. You can just do

const result = someArray.map(...)

Or even faster, since you're not doing anything more here:

return someArray.map(...).join(...)

[yaripey]

The task implies that the catwoman would ALWAYS say what the cat says. It means that if we change the cat's saying later in the code, Catwoman should say the new line, not the initial, as yours does. You need to find a way to connect catwoman's saying with the cat's object, not just assign an initial cat.saying value.

[yaripey]

If you're .maping on persons, then elements inside are persons, right? item isn't descriptive enough.

[yaripey]

What obj, exactly? I believe this should be person.

[yaripey]

You didn't see a problem in this task, because it's pretty simple here, but note that your .friends for all other objects is an array. And your catWoman.friends is a string for some reason. The only thing that you're doing here is printing stuff out, so it didn't invoke an error, but imagine that you did something like .friends.map to print every friend separately, the code wouldn't work here, since string doesn't have .map() method.

If you wish to specify that catWoman has only one friend, you should still keep the data type and just make it like this:

catWoman.friends = [cat.name];

[yaripey]

LGTM Let's wait for @OleksiyRudenko's verdict.

[deveLabR]

I need to press Re-review?

[OleksiyRudenko]

@deveLabR great job!