Document Object Model #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete one alert =)
A-Ostrovnyy
requested changes
Aug 1, 2022
|
@Eugene-CG Why do you close PR? |
A-Ostrovnyy
requested changes
Aug 9, 2022
deleted html comment
A-Ostrovnyy
requested changes
Aug 10, 2022
|
Have a little problem with Logo, few minutes |
A-Ostrovnyy
reviewed
Aug 10, 2022
| @@ -61,7 +61,7 @@ const fillMenuList = (event) => { | |||
| menuList.appendChild(li); | |||
|
|
|||
| const a = document.createElement("A"); | |||
| a.setAttribute("href", "#"); | |||
| a.setAttribute("href", ""); | |||
There was a problem hiding this comment.
For future works better use # instead of the empty href attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document Object Model
Demo
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.