js-dom

[Yasya23]

js-dom

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure you haven't made common mistakes

Universal recommendations:

• Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
• Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
• Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

[Yasya23]

It seems to me that I checked everything according to the instructions. Please rewiew.

[madmaxWMFU]

Nice work! See some comments below.

[madmaxWMFU]

ID is a unique number.
Change the property name to category.

[Yasya23]

Thanks for checking! Fixed it.

[madmaxWMFU]

I think you can realize it in CSS. Add use the methods Element.classList.add/remove/toggle.

[Yasya23]

Fixed it.

[madmaxWMFU]

Add a listener for the parent element.

const menuList = document.querySelector('.navigation');
menuList.addEventListener('click', changeImagesByClick)

[Yasya23]

Fixed it.

[madmaxWMFU]

Rename to 'animalList'. The naming of variables must be more informative.

[Yasya23]

Fixed it.

[madmaxWMFU]

Create render function.
Add initial value to first render to list.

[Yasya23]

I'm not sure I did it right.

[Yasya23]

Thanks for the help!

[madmaxWMFU]

Great, I approve of your work. Good luck with future tasks!