Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html css popup #205

Merged
merged 5 commits into from
Aug 25, 2022
Merged

Html css popup #205

merged 5 commits into from
Aug 25, 2022

Conversation

Maksym-Perepelytsia
Copy link
Contributor

Hooli-style Popup

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@github-actions
Copy link

Hey!

Congratulations with your PR! 😎😎😎

Please, be sure you haven't followed common mistakes.

Also, be aware, that if you would silently ignore this recommendation, a mentor may think that you are still working on fixes. And your PR will not be reviewed. 😒

@Maksym-Perepelytsia
Copy link
Contributor Author

I changed some CSS code because the 'More Cats' focus styles weren't working.

@HannaSyn HannaSyn self-assigned this Aug 23, 2022
Copy link
Contributor

@HannaSyn HannaSyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did good job!
Please, see my comments below

submissions/Maksym-Perepelytsia/html-css-popup/index.html Outdated Show resolved Hide resolved
submissions/Maksym-Perepelytsia/html-css-popup/style.css Outdated Show resolved Hide resolved
submissions/Maksym-Perepelytsia/html-css-popup/style.css Outdated Show resolved Hide resolved
submissions/Maksym-Perepelytsia/html-css-popup/style.css Outdated Show resolved Hide resolved
submissions/Maksym-Perepelytsia/html-css-popup/style.css Outdated Show resolved Hide resolved
submissions/Maksym-Perepelytsia/html-css-popup/style.css Outdated Show resolved Hide resolved
submissions/Maksym-Perepelytsia/html-css-popup/style.css Outdated Show resolved Hide resolved
@Maksym-Perepelytsia
Copy link
Contributor Author

@HannaSyn Thank you for your feedback. Please, review my latest edits according to your comments.

Copy link
Contributor Author

@Maksym-Perepelytsia Maksym-Perepelytsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alt attributes are now empty.
In the CSS file, id selectors changed to class selectors.
Styling by tags was replaced with styling by classes.
And I fixed the missing spaces.

@HannaSyn HannaSyn merged commit d080c71 into kottans:main Aug 25, 2022
@Maksym-Perepelytsia
Copy link
Contributor Author

Thank you very much.
Have a nice day 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants