vovan-DOM

[vovan-zt]

DOM

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure you haven't made common mistakes

Universal recommendations:

• Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
• Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
• Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

Sincerely yours,
Submissions Kottachecker 😺

[madmaxWMFU]

Good work. See some comments below.

[madmaxWMFU]

Try property toggle

function toggleMenu() {
 .....
}
humburgerBtn.addEventListener('click', toggleMenu))
closeBtn.addEventListener('click', toggleMenu))

[madmaxWMFU]

Separate eventListener and function.

[madmaxWMFU]

If I'm not mistaken, it will be more correct target.dataset.content

[madmaxWMFU]

Separate listener and function.
menuList.addEventListener('click', showContent)

[madmaxWMFU]

Leave only

window.addEventListener ('DOMContentLoaded', () => {
    menuList.addEventListener('click', showContent);
    hamburgerBtn.addEventListener('click', toggleMenu);
    closeBtn.addEventListener('click', toggleMenu);  
})

[madmaxWMFU]

Great, I approve of your work. Good luck with the future tasks!