Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js-dom #14

Merged
merged 4 commits into from
Aug 7, 2022
Merged

js-dom #14

merged 4 commits into from
Aug 7, 2022

Conversation

AntonKottans
Copy link
Contributor

js-dom

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

Copy link

@yaripey yaripey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Let's see what can be done to make it even better.

submissions/antonkottans/js-dom/script.js Outdated Show resolved Hide resolved
submissions/antonkottans/js-dom/script.js Outdated Show resolved Hide resolved
submissions/antonkottans/js-dom/script.js Outdated Show resolved Hide resolved
submissions/antonkottans/js-dom/script.js Outdated Show resolved Hide resolved
submissions/antonkottans/js-dom/script.js Outdated Show resolved Hide resolved
submissions/antonkottans/js-dom/script.js Show resolved Hide resolved
submissions/antonkottans/js-dom/script.js Outdated Show resolved Hide resolved
submissions/antonkottans/js-dom/style.css Show resolved Hide resolved
submissions/antonkottans/js-dom/style.css Show resolved Hide resolved
submissions/antonkottans/js-dom/style.css Outdated Show resolved Hide resolved
submissions/antonkottans/js-dom/script.js Outdated Show resolved Hide resolved
submissions/antonkottans/js-dom/script.js Outdated Show resolved Hide resolved
submissions/antonkottans/js-dom/script.js Outdated Show resolved Hide resolved
submissions/antonkottans/js-dom/script.js Outdated Show resolved Hide resolved
@AntonKottans AntonKottans requested review from yaripey and Roophee July 28, 2022 15:11
Copy link
Contributor

@Roophee Roophee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have made a great job!!!
But we can make it better. Please, fix comments issues.
Thanks.

submissions/antonkottans/js-dom/script.js Outdated Show resolved Hide resolved
submissions/antonkottans/js-dom/script.js Outdated Show resolved Hide resolved
@AntonKottans AntonKottans requested a review from Roophee August 1, 2022 11:47
@zonzujiro zonzujiro merged commit 4c6ac36 into kottans:main Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants