-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html-css-popup #10
html-css-popup #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice custom design. Let's see how you can improve your work.
@@ -0,0 +1,203 @@ | |||
@charset "UTF-8"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add autogenerated files into the homeworks folder. Only files you yourself typed in.
font-weight: 400; | ||
} | ||
|
||
/*--------------------*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to have dividers of some sort, it is also nice to name them. Like
/*----------Header----------*/
or something like that.
font-weight: bold; | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty line.
max-height: 70vh; | ||
overflow: hidden; | ||
overflow-y: auto; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty line.
margin: 0 auto; | ||
position: relative; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two empty lines. It is fine to leave an empty line between two blocks, but be consistant, you have only one line between other blocks.
<div class="header__wrapper_logo">FOOD DELIVERY</div> | ||
<div class="header__wrapper_checkbox headerInput"> | ||
<label for="drop">Choose Delivery</label> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty line.
<div class="main__wrapper_item mainList"> | ||
<ul class="mainList__list"> | ||
<li class="mainList__list_item listItem"><a class="imageAnchor" href="#"><img | ||
src="./img/mcdonalds.svg" alt="mcdonalds"></a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alt
attribute for navigation elements, like icons, should be left empty.
Good work! |
Nice work! |
thanks!) |
HTML CSS Popup
Demo |
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.