Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casing broken since the recent dashing changes #60

Open
DerDakon opened this issue Feb 27, 2016 · 11 comments
Open

Casing broken since the recent dashing changes #60

DerDakon opened this issue Feb 27, 2016 · 11 comments

Comments

@DerDakon
Copy link
Collaborator

This is how OpenRailwayMap looks with the original rendering code:
casing-old

This is how it looks now:
casing-new

The casing is now either always on or always off as it looks to me. The change is the new dashing code from @braandl.

@braandl
Copy link
Contributor

braandl commented Feb 29, 2016

Hm, I use the new code in my Application, and I can not find any of that behavior so far. When does this happen?
no-dashing-issues

@DerDakon
Copy link
Collaborator Author

It's this code.

@braandl
Copy link
Contributor

braandl commented Mar 1, 2016

Hm, when I define casing and dashing in the same selector, it works as intended, i think?
Maybe you should define the dashes in "way|z9-[railway=razed].tracks", too?

I am not sure what the correct behavour is...

image

@DerDakon
Copy link
Collaborator Author

DerDakon commented Mar 1, 2016

Your case looks correct.

@DerDakon
Copy link
Collaborator Author

DerDakon commented May 7, 2016

Which version of Leaflet do you use? Which Browser?

@braandl
Copy link
Contributor

braandl commented May 7, 2016

Leaflet 0.7.7 and I did test it with Google Chrome, Firefox on Windows, Ubuntu , Opera on Windows and Mobile and Safari MacOsX 10.11 aswell as on iPhones with iOS 9.3 and on an iPad Air having no issues that I am aware of.

@braandl
Copy link
Contributor

braandl commented May 7, 2016

All the Browsers were always updated to the latest stable version.

@DerDakon
Copy link
Collaborator Author

DerDakon commented May 7, 2016

We were still using Leaflet 0.6.2 back then, but meanwhile I upgraded. I'll test again.

@DerDakon
Copy link
Collaborator Author

DerDakon commented May 7, 2016

abandoned

South of the bridge this is just one way, which in the middle stops showing any casing. I changed the base color to green just to make sure there are no other styles interfere with that.

Have you tried your code when the line crosses tile borders?

@braandl
Copy link
Contributor

braandl commented May 7, 2016

Yes, it works on my Installation that provides tiles for entire regions as gjson

@braandl
Copy link
Contributor

braandl commented May 7, 2016

multiple-tiles-casing

The only difference I can see so far, is that my leaflet configuration is using elements to render the tiles in, and openrailwaymap.org deliveres to me.
But I guess you are rendering it on a canvas to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants